Repository navigation
🐛 fix(maturin): build cross targets again - #47
Merged
Merged
Conversation
The wheel workflow passed `--interpreter 3.15` to every matrix entry, so cross-compiled targets (aarch64 and riscv64 via zig or the cross image, macOS x86_64 on arm runners) failed: maturin finds no 3.15 interpreter there. Entries now pass `--interpreter` only when they set `python`. sccache stays off on Windows, where it broke MSVC builds of C dependencies such as libmimalloc-sys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared maturin wheel workflow from 6.5.0 fails on cross-compiled targets and on Windows ARM, which blocks simplint and toml-fmt from adopting it.
--interpreter 3.15went to every matrix entry. Cross targets (aarch64 and aarch64-musl via zig, riscv64 via the cross image, macOS x86_64 on arm runners) have no 3.15 host interpreter, so maturin stopped withFailed to find a python interpreter from 3.15. An entry now passes--interpreteronly when it setspython; native entries without it still build for the job's Python 3.15.sccache was on for Windows entries in non-release builds and broke the MSVC build of
libmimalloc-sys(C1083: Cannot open source file: '/WX-'). Windows entries now build without it, as simplint's own workflow did before.