Skip to content

🐛 fix(workflows): find dev plugin ZIPs and README revs - #48

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/jetbrains-glob-mirror-readme
Nov 4, 2026
Merged

gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/jetbrains-glob-mirror-readme

Conversation

@gaborbernat

Copy link
Copy Markdown
Member

Two shared workflows from 6.5.0 fail for real callers: jetbrains-fish can't pass its plugin check, and the pyproject-fmt and tox-toml-fmt mirrors would publish a README with the old version.

jetbrains-plugin-check matched the plugin ZIP as *-<version>.zip. A development version builds <name>-<version>+<build>.zip (jetbrains-fish's build.gradle.kts appends the commit), so the check reported expected one plugin ZIP for version 0.1.11-dev, found 0. It now also matches the +<build> form.

publish-pre-commit-mirror rewrote only a quoted rev: "..." line. Both mirror READMEs write rev: v2.30.3 unquoted, so the step changed nothing. The rewrite now keeps whichever quoting the README uses, and the step fails when the README has no rev: line rather than publishing a stale version.

The JetBrains check looked for `*-<version>.zip`, but a development
version builds `<name>-<version>+<build>.zip`, so jetbrains-fish found no
archive for 0.1.11-dev.

The mirror's README update matched only a quoted `rev: "..."`. The
pyproject-fmt and tox-toml-fmt READMEs write it unquoted, so the README
kept the old version. It now keeps either quoting style and fails when
the README has no `rev:` line.
@gaborbernat gaborbernat added the bug Something isn't working label Nov 4, 2026
@gaborbernat
gaborbernat merged commit 31c78ca into tox-dev:main Nov 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant