Repository navigation
👷 ci(news): stop cancelling the news check - #346
Merged
Merged
Conversation
Opening a PR with labels fires `labeled` a moment after `opened`, and the concurrency group cancelled the first run, which the PR listed as a failed check. github-workflows 6.3.0's `validate-news` passes at once for a label set at opening, so runs no longer need to cancel each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a pull request with labels, as
gh pr create --labeldoes, fireslabeleda moment afteropened. Both started the news check, and the concurrency group cancelled the first run, which the PR then listed as a failed📝 News fragmentcheck while the other run passed. 👷This moves the news check to github-workflows 6.3.0, whose
validate-newspasses at once for a label set within a minute of opening since the run for opening already reads the current labels, and stops cancelling runs in progress. The check keeps its name, so the ruleset needs no change.