Repository navigation
🐛 fix(discovery): don't probe PATH directories as interpreters - #247
Open
qodelicious wants to merge 1 commit into
Open
qodelicious wants to merge 1 commit into
qodelicious wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iter_interpreters()with no key builds an emptyPythonSpec(""), so inpath_exe_finderthe literal-name check doespath / "", which is just the PATH directory. It exists, so every PATH entry gets handed toPathPythonInfo.from_exeas if it were an interpreter. Each one fails withPermission deniedand is retried once, so on a normal PATH that's two wasted subprocesses per directory, plus noise in the debug log likeThe check now uses
is_file()instead ofexists(), so only an actual file with that name is probed. It still follows symlinks like before.Added a test with a PATH holding one
python3.99and no key. It asserts only that file gets probed. It fails on main (the directory shows up first) and passes with the fix.