Repository navigation
Remove no optional hook - #7
Open
Polandia94 wants to merge 2 commits into
Open
Polandia94 wants to merge 2 commits into
Polandia94 wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Removed the no optinal Hook, solve #6
Are there changes in behavior for the user?
For users that are using the ful pre-commit should not be any change. However if they are running no-optional explicitly with flags they will have to stop it, and if they are skipping ruff they will lose the no optional fix.
Is it a substantial burden for the maintainers to support this?
No, it just remove a dependency
Related issue number
#6
Checklist
code of conduct