Repository navigation
relpath: let os.path.relpath detect different drives on Windows - #382
Merged
Merged
Conversation
The os.path.commonpath() guard added in a80305b also raises ValueError when one path has a root and the other does not, as with a UNC share root without a trailing separator ("\\srv\sh"). relpath() then returned the absolute path instead of a relative one. os.path.relpath() raises ValueError on Windows only when the drives differ (or the path is empty, which abspath rules out), so catch that instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #375. The
os.path.commonpath()guard inrelpath()raisesValueErrornot only for paths on different drives but also when one path has a root and the other does not. A UNC share root without a trailing separator (\\srv\sh) has no root, sorelpath(r"\\srv\sh\x", r"\\srv\sh")returned the absolute path instead ofx.os.path.relpath()on Windows raisesValueErroronly when the drives differ (or for an empty path, whichabspathrules out), so call it directly and fall back topathonValueError. Non-Windows behaviour is unchanged.Behaviour on Windows (checked with
ntpath):commonprefix)commonpath)D:\x,C:\aC:\a\b,C:\abbbc:\a\b,C:\abb\\srv1\sh\x,\\srv2\shValueError\\srv\sh\x,\\srv\shxxNot verified on a real Windows share;
relpathhas no tests in this repo.🤖 Generated with Claude Code