Skip to content

fix(webapp): enforce keyboard interaction safeguards - #4702

Merged
carderne merged 1 commit into
fix/webapp-tree-interactions-tri-13381from
fix/webapp-interaction-lints-tri-13381
Aug 19, 2026
Merged

fix(webapp): enforce keyboard interaction safeguards#4702
carderne merged 1 commit into
fix/webapp-tree-interactions-tri-13381from
fix/webapp-interaction-lints-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Enable keyboard-event and static-element interaction safeguards across the dashboard.

Earlier stack changes move actionable behavior to native controls. This final enforcement keeps narrowly documented exceptions for focus forwarding, scoped Escape handling, CodeMirror focus, and pointer-driven table column resizing.

jsx-a11y/no-autofocus remains disabled.

Base: #4701

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7c09b8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6b10419-dc44-431f-896f-c1f2295c08ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 688e5c3 to f64f330 Compare August 19, 2026 11:01
@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from f64f330 to e1f32cb Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from e1f32cb to 646fe97 Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 646fe97 to 33a32a5 Compare August 19, 2026 11:50
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch 2 times, most recently from 1c37207 to 3d1bb06 Compare August 19, 2026 11:56
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch 2 times, most recently from 0187d2a to 30d7f93 Compare August 19, 2026 12:00
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch 2 times, most recently from 4b70f0c to daa6728 Compare August 19, 2026 12:41
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from daa6728 to f78c4e2 Compare August 19, 2026 13:07
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from f78c4e2 to 3c0a9d5 Compare August 19, 2026 13:09
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 3c0a9d5 to 708a391 Compare August 19, 2026 13:36
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 708a391 to d57a9bf Compare August 19, 2026 13:38
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from d57a9bf to 00ace8f Compare August 19, 2026 14:04
stack merge was automatically disabled August 19, 2026 14:38

Pull Request is not mergeable

stack merge was automatically disabled August 19, 2026 14:47

Pull Request is not mergeable

stack merge was automatically disabled August 19, 2026 14:49

Pull Request is not mergeable

stack merge was automatically disabled August 19, 2026 14:50

Pull Request is not mergeable

@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 00ace8f to 5f56c7c Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@5f56c7c

trigger.dev

npm i https://pkg.pr.new/trigger.dev@5f56c7c

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@5f56c7c

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@5f56c7c

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@5f56c7c

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@5f56c7c

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@5f56c7c

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@5f56c7c

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@5f56c7c

commit: 5f56c7c

@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 5f56c7c to 2b3ead2 Compare August 19, 2026 15:00
@carderne
carderne force-pushed the fix/webapp-interaction-lints-tri-13381 branch from 2b3ead2 to 7c09b8c Compare August 19, 2026 15:20
@carderne
carderne merged commit 23c5619 into main Aug 19, 2026
37 checks passed
@carderne
carderne deleted the fix/webapp-interaction-lints-tri-13381 branch August 19, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants