Skip to content

fix(smoke): pass a test collection to every production smoke step - #1257

Merged
trunk-io[bot] merged 2 commits into
mainfrom
max/smoke-prod-test-collection
Oct 27, 2026
Merged

fix(smoke): pass a test collection to every production smoke step#1257
trunk-io[bot] merged 2 commits into
mainfrom
max/smoke-prod-test-collection

Conversation

@max-trunk

@max-trunk max-trunk commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The production smoke-test steps that didn't specify a test collection now fail, because uploads for this organization must name one. This passes --test-collection-id 4B2wfoEU (the collection Upload to production already uses) to:

  • Run tests on production
  • Upload Swift tests on production
  • Upload to production with public repo id
  • Upload to production with variant

🤖 Generated with Claude Code

@trunk-io

trunk-io Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

😎 Merged successfully - details.

@max-trunk max-trunk changed the title fix(smoke): name a test collection on every production smoke step fix(smoke): pass a test collection to every production smoke step Oct 27, 2026
@max-trunk @claude
fix(smoke): pass a test collection to every production smoke step
1ba7544 
Uploads for this organization must name a test collection. Pass the one
the production upload step already uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@max-trunk
max-trunk force-pushed the max/smoke-prod-test-collection branch from 4320389 to 1ba7544 Compare October 27, 2026 14:44
@max-trunk @claude
chore(smoke): drop collection link comments from production steps
f0c5c85 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trunk-staging-io

trunk-staging-io Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
pending_quarantine_test should be quarantined when run with variant A test marked as pending was expected to fail but unexpectedly passed. Logs ↗︎
variant_quarantine_test should be quarantined when run with variant The test failed because it expected 2 + 2 to equal 5, but the result was 4. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.16%. Comparing base (ab283ab) to head (f0c5c85).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   83.94%   84.16%   +0.21%     
==========================================
  Files          74       74              
  Lines       17958    17958              
==========================================
+ Hits        15075    15114      +39     
+ Misses       2883     2844      -39

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io
trunk-io Bot merged commit 6c4025c into main Oct 27, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acatxnamedvirtue acatxnamedvirtue acatxnamedvirtue approved these changes
@TylerJang27 TylerJang27 TylerJang27 approved these changes
@dfrankland dfrankland Awaiting requested review from dfrankland

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@max-trunk @codecov-commenter @acatxnamedvirtue @TylerJang27