Repository navigation
fix(cli): clean up link and cursor escapes in non-terminal output - #1261
Merged
Merged
Conversation
OSC 8 hyperlink escapes are only emitted when superconsole is drawing to a compatible TTY. Log viewers such as GitHub Actions drop the link text along with the escape, so test and upload links disappeared from CI logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
…minal The superconsole upgrade wraps every frame in cursor hide/show escapes, which GitHub Actions prints as 25l/25h at the start of each line. Filter them from stderr when superconsole falls back to its non-TTY console. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 83.94% 84.20% +0.25%
==========================================
Files 74 74
Lines 17958 18003 +45
==========================================
+ Hits 15075 15159 +84
+ Misses 2883 2844 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dfrankland
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1230 changed two things that show up badly in log viewers that aren't a terminal, such as GitHub Actions:
⤷test links and the🏷️ Upload:link are empty.25l/25hat the start of lines. The superconsole upgrade wraps every frame in cursor hide/show escapes (ESC[?25l/ESC[?25h). The log viewer doesn't recognise them and prints the tail of each one.This PR:
SuperConsole::compatible()is true, i.e. stderr is an interactive, non-dumb terminal. Otherwise the URL is printed as plain styled text, as before Make the URLs clickable #1230.Testing
trunk-analytics-cli validatewith stderr redirected to a file: no cursor visibility or OSC 8 escapes in the output.cargo test -p trunk-analytics-cli --test upload: all pass except the three Swift xunit tests, which fail the same way onmainlocally.🤖 Generated with Claude Code