Repository navigation
fix(cli): CLI output inconsistencies (logs to stderr, -qqq, deprecation warnings, test progress) - #1266
Open
dfrankland wants to merge 5 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
+ Coverage 85.42% 85.77% +0.35%
==========================================
Files 86 86
Lines 19235 19214 -21
==========================================
+ Hits 16431 16481 +50
+ Misses 2804 2733 -71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Leaves stdout free for the command's own output, which the upcoming `--output-format json` relies on. Logs only show with `--verbose`, so default output is unchanged. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`to_trace_filter` mapped `LevelFilter::Off` to `TRACE`, so the quietest setting logged the most. Map it to `LevelFilter::OFF` and filter events by level in the console layer. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As `tracing::error!`, each deprecation counted as an error in Sentry even though nothing failed. Log them with `warn!` and tag them with a `deprecated_flag` field. Sentry now records warnings with that field as warning-level events, with the same tags as errors, so we can still see which customers use deprecated flags. Other warnings stay breadcrumbs. This also starts reporting `--use-quarantining`, which was already a `warn!` and so never reached Sentry. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`run_test` didn't pass its `render_sender` to `run_upload`, so `test` skipped the slow-request messages that `upload` shows. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dfrankland
force-pushed
the
dylan/trunk-22400-fix-cli-output-inconsistencies-log-stream-qqq-deprecation
branch
from
October 29, 2026 17:40
1392d05 to
5c6f239
Compare
This was referenced Oct 29, 2026
acatxnamedvirtue
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TRUNK-22400. Part of TRUNK-18881, and needed before TRUNK-22405 (
--output-format json), which needs stdout free of logs.One commit per fix:
-v, so default output is unchanged.-qqqturns console logs off.to_trace_filtermappedLevelFilter::OfftoTRACE, so the quietest setting logged the most.warn!instead oferror!, and still go to Sentry. Each one carries adeprecated_flagfield. Sentry records these as warning-level events with the samecommand_name/org_url_slug/repo_roottags as errors, so we can still see who uses deprecated flags, but they no longer count as errors. Other warnings are still sent only as breadcrumbs.--use-quarantiningwas already awarn!, so this is the first time it reaches Sentry.impl EndOutput for TestRunResult.testnow shows the slow-API progress messages thatuploadshows.run_testnow passes itsrender_sendertorun_upload.Testing
uploadintegration tests:-v, a debug log appears on stderr and not on stdout, and the--teamdeprecation appears asWARN.-qqq, the debug log appears on neither stdout nor stderr.main.falls_back_to_binary_filenow looks for its log on stderr.sentry::test::with_captured_events:warn!isn't sent.testprogress messages, which would need a deliberately slow mock server.Release note
With
-v/--verbose, log lines now go to stderr instead of stdout. Scripts that read verbose logs from stdout need to read stderr instead.🤖 Generated with Claude Code