Repository navigation
trunk-merge/pr-1247/85daf061-ba2c-4d99-9e4f-9833c6793aa6 - #1276
Closed
trunk-io[bot] wants to merge 12 commits into
Closed
trunk-io[bot] wants to merge 12 commits into
trunk-io[bot] wants to merge 12 commits into
Conversation
…sults are found With --allow-empty-test-results=false (or its alias --allow-missing-junit-files=false), an upload that finds no test results exits 70 with just "No test output files found to upload." It now names where it looked and the flag that made it fail: No test results found to upload in: ./*. Failing because --allow-empty-test-results (or its alias --allow-missing-junit-files) is false; set it to true to continue without test results. Both spellings are named because clap can't tell which was passed, and the GitHub Action passes the alias. Part of TRUNK-19074. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gem documents TRUNK_DISABLE_QUARANTINING ("Set to 'true' to disable
quarantining"), but it only ever reached the upload step. The check
that runs when a test fails never read it, so failures were still
looked up and quarantined.
With TRUNK_DISABLE_QUARANTINING=true, a failure is no longer looked up
or quarantined, and the run ends with a note saying so. The gem's upload
telemetry reports the quarantine query result as Disabled rather than
Skipped, as the CLI does for --disable-quarantining.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`trunk-analytics-cli test -- <command>` exited 0 when the command couldn't be started, for example because of a typo in its name. It printed "Unable to connect to trunk's server", so a CI job with a broken test command passed. The error from starting the process is an io::Error, which the error report treats as a refused connection, and those exit 0 by design. Now it's raised like the CLI's other can't-continue errors, so `test` exits 70 and prints "Couldn't run the test command `<command>`: <reason>". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`upload --allow-forked-pr-uploads` without `--test-collection-id` (or with a blank one) exited 0. The check was added to stop exactly this misconfiguration from passing as a green step. Its error had no exit code of its own, though, so it failed open like any unclassified error. It's now raised as an InterruptingError, like the CLI's other can't-continue errors, so the run exits 70. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 85.42% 85.67% +0.25%
==========================================
Files 86 86
Lines 19235 19259 +24
==========================================
+ Hits 16431 16500 +69
+ Misses 2804 2759 -45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1247/85daf061-ba2c-4d99-9e4f-9833c6793aa6
branch
October 29, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 41f781fcce459e370e5db0a9f039001d1d775014.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1247.
Dependencies
This pull request depends on the changes from pull requests 1252, 1250, and 1251.