Repository navigation
ci(smoke): name the staging test collection on every staging upload - #1307
Merged
Merged
Conversation
trunk-staging-org now requires a test collection, so the staging smoke
steps that named none are refused ("Your Trunk organization uses test
collections, so uploads must name one"). That fails Smoke Test Main since
2026-11-09 18:08 and the 0.17.0-beta.3 release's smoke test. Name
z2dzjLHm (analytics-cli-smoke-tests), which the other staging steps
already use, on the four that didn't.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
Contributor
Author
|
/trunk merge --direct |
|
In this organization, users with the "Member" role cannot send a PR directly to the queue ( |
dfrankland
approved these changes
Nov 9, 2026
TylerJang27
approved these changes
Nov 9, 2026
Contributor
Author
|
/trunk merge |
TylerJang27
pushed a commit
that referenced
this pull request
Nov 10, 2026
…1307) trunk-staging-org now requires a test collection, so the staging smoke steps that named none are refused ("Your Trunk organization uses test collections, so uploads must name one"). That fails Smoke Test Main since 2026-11-09 18:08 and the 0.17.0-beta.3 release's smoke test. Name z2dzjLHm (analytics-cli-smoke-tests), which the other staging steps already use, on the four that didn't. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 4252b5d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trunk-staging-orgnow requires a test collection on every upload, so the staging smoke steps that named none are refused:The step's fixture test is meant to fail, so with the upload refused it isn't quarantined and the CLI exits 100. This has failed Smoke Test Main since 2026-11-09 18:08, and the 0.17.0-beta.3 release's Linux smoke test.
This names
z2dzjLHm(analytics-cli-smoke-tests), which the other staging steps already use, on the four that didn't:perform_smoke_test: "Run tests on staging" and "Upload to staging with public repo id"perform_gitlab_smoke_test: "Run tests on staging" and "Upload to staging"Nothing else changes. #1298 (TRUNK-23150) makes the collection required in the CLI and moves the public-repo-id step to the fork lane; it touches the same lines and will need a small rebase. This gets cherry-picked onto
0.17.xfor 0.17.0-beta.3.Part of TRUNK-23146
🤖 Generated with Claude Code