Repository navigation
fix(installer): stage the branded dmg background at the window's point size (#322) - #323
Merged
Merged
Conversation
…t size Current Finder draws the icon-view backdrop 1:1 at its native pixel size and never scales it to the window, so a 2x (1320x800) artwork rendered only its top-left quarter (issue #322). The packager now resamples the staged copy to the window's 660x400 point size with sips and verifies the result; products keep authoring 2x artwork for sharpness. The live DMG test gates the staged dimensions, and configuration.md documents the real behavior plus the title-bar and icon-label safe zones.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #322. Finder no longer scales the icon-view backdrop: it draws the PNG 1:1 at native pixel size, so the family convention of authoring 2x artwork (1320x800 for the 660x400 window) rendered only the top-left quarter of the image — reproduced and confirmed by the Fulcrum install (fulcrum#92 fixed it product-side).
create-branded-macos-dmg!now resamples the staged.background/background.pngto the window's point size (660x400) viasips -zwhenever its pixel size differs, and re-reads the result to verify.raster-pixel-size(sips-based reader) is exported via test-support and unit-tested on macOS.docs/configuration.mdno longer claims Finder scales the backdrop; it documents the 2x authoring convention, the aspect requirement, and the title-bar / icon-label safe zones.Validation
raco test rivet/tests/macos-installer.rkt: 18 passed locally, including a full live branded DMG build whose mounted background measured exactly 660x400 from a 1x1 source.raco test rivet/ rivet-cli/: 10204 passed.