[pull] master from ruby:master - #1329
Merged
Merged
Conversation
Previously we were skipping the read from the inline cache, but still writing to it every time this was called. We should either use the inline cache or skip the it entirely. This commit checks the cache before running the slowpath.
… the lockfile bundle install and bundle check in frozen mode printed "Cannot write a changed lockfile while frozen." to stderr and exited 0 when regenerating the lockfile would change it, so invalid lockfiles went unnoticed in CI. Raise ProductionError instead. To avoid failing on environment-only differences, ignore BUNDLED WITH even across bundler major versions and reproduce the locked bundler CHECKSUMS entry instead of recording one for the running bundler version. ruby/rubygems#9549 ruby/rubygems@8c9fd14167 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ow rejects These lockfiles deviated from the canonical form bundler generates (a missing or extra trailing slash on the source remote, unsorted GEM and DEPENDENCIES entries), so frozen mode used to print a warning and keep going. Now that a changed lockfile raises in frozen mode, align them with what bundler actually writes. ruby/rubygems@2a2b5ccb84 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
`bundle lock --add-platform A --add-platform B` silently dropped all but the last occurrence, because Thor array options are last-wins by default. Mark `--add-platform`, `--remove-platform` and `--update` as repeatable and normalize the parsed values, so every occurrence takes effect. Fixes ruby/rubygems#5357. ruby/rubygems@54ae9ae3a7 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
econv_memsize only counted the rb_econv_t struct, but it should use rb_econv_memsize.
This is really hot code. Use the Entry API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )