Port LAPP appliance to TurnKey 19 - #17
Open
lirazsiri wants to merge 6 commits into
Open
Conversation
Move the appliance to the Debian 13 web and PostgreSQL stack, remove package names that no longer have Trixie candidates, and explicitly retain Composer from Debian. Clarify the supported language integrations and v19 component contract in the README and changelog. Add a functional acceptance script and evidence crosswalk for Apache HTTPS and PHP, PostgreSQL first-boot authentication, Adminer, CGI language support, Composer, Webmin modules, a database-backed PHP request, and the non-destructive APT update path. Static verification included bash syntax checking and git diff validation; the Docker appliance acceptance run follows this commit.
The first normal-runtime attempt reached active Apache and PostgreSQL services but the test exited with curl status 23. Under pipefail, grep can close a successful response stream after matching and make curl report a write error, especially for the PHP information page. Retain each HTTP response in the existing temporary response file before checking its marker. This preserves the same functional assertions while allowing curl to complete normally. Verified with bash syntax checking and git diff validation; the clean Docker acceptance rerun follows.
The second runtime attempt reached the database-backed PHP request after all earlier stack checks passed, but Apache returned HTTP 500. Debian Apache runs with PrivateTmp=true, so its PHP worker could not see the credential fixture created in the container namespace under /tmp. Store the disposable test credential under the harness runtime directory in /run, retaining the same root:www-data mode and cleanup. This changes only the acceptance fixture boundary and lets Apache exercise PostgreSQL with the first-boot password. Verified against the Trixie Apache unit and with bash syntax and diff checks; the clean Docker acceptance rerun follows.
The third runtime attempt completed the Apache, PHP, PostgreSQL, and Adminer flow and reached the updater check. It failed because the test assumed a Debian source filename, while the common v19 build correctly emits Deb822 files named sources.sources and security.sources.sources. Verify the Trixie suite and Debian URI from Deb822 content instead of a filename, while retaining the Bookworm exclusion. Require Adminer’s authenticated Logout marker, confirmed against a disposable Trixie Adminer and PostgreSQL fixture, so the postgres credential claim is exercised directly. Bash syntax and diff checks pass; the final clean Docker acceptance rerun follows.
The fourth runtime execution completed normal boot and returned from the application test without a result file. The shared runner then reported only its failed copy, masking which final assertion prevented the evidence payload from being written. Add a failure-only ERR trap that reports the LAPP test line while leaving every assertion and success path unchanged. This is scoped to diagnosing the current concrete acceptance failure and does not modify the shared harness. Bash syntax, trap behavior, and diff checks pass.
Replace the generic report location with the exact final run, source and harness revisions, configured-root mode, and tested package versions. This ties the README crosswalk and updater claims to a reproducible passing artifact without changing appliance behavior. Verified with the full Docker rootfs acceptance run 20260824t063019z-367-29300, which returned exit_status=0 and verdict=PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation