fix(orchestrator): carry a failed batch's reason to the request error log - #616
Open
behinddwalls wants to merge 2 commits into
Open
fix(orchestrator): carry a failed batch's reason to the request error log#616behinddwalls wants to merge 2 commits into
behinddwalls wants to merge 2 commits into
Conversation
… log When a batch failed, the request that could not land ended in `error` with an empty message: mergesignal and speculate recorded only the terminal batch state, and conclude terminated the request with an empty reason — so a "did not land: error" carried no diagnostic at all. Record why the batch failed on the batch itself when it is marked failed: the merge result's reason on the merge path, and "no speculation path could pass" on the speculate path. Persist it through the batch store (new failure_reason column, new Batch.FailureReason field), and have conclude pass it to the request's terminal log instead of an empty string. The dead-letter path already threads its own reason and is unchanged.
The final "N request(s) did not land" line printed only id=status, so a failure read as "demo-queue/630=error" with no reason — even once the orchestrator began recording one on the request's terminal log. Append the request's last error to each failed entry when it has one, so a watched or scripted run reports why a change did not land, not only that it did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a batch failed, the request that could not land ended in
errorwith an empty message: mergesignal and speculate recorded only the terminal batch state, and conclude terminated the request with an empty reason — so a "did not land: error" carried no diagnostic at all.Record why the batch failed on the batch itself when it is marked failed: the merge result's reason on the merge path, and "no speculation path could pass" on the speculate path. Persist it through the batch store (new failure_reason column, new Batch.FailureReason field), and have conclude pass it to the request's terminal log instead of an empty string. The dead-letter path already threads its own reason and is unchanged.
The demo client's run summary also surfaces the reason, so a failed request reads
id=error: <reason>instead of a bareid=error.Test Plan
✅ mergesignal records the merge reason on the batch; conclude carries it to the request's terminal log (new test); the batch store round-trips
failure_reason; the client summary includes the note.//submitqueue/...green, CI gates clean.Stack