Skip to content

feat(stovepipe): Publish issue-tracking updates - #939

Closed
prathshenoy wants to merge 1 commit into
codex/stovepipe-issuetrack-deliveryfrom
codex/stovepipe-issuetrack-publish
Closed

prathshenoy wants to merge 1 commit into
codex/stovepipe-issuetrack-deliveryfrom
codex/stovepipe-issuetrack-publish

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • Notify issue tracking after build analysis saves its detected issues, including when a completed build reports none.
  • Send updates in queue order and wait for the request’s chosen build before requesting finalization, without enabling the consumer.

Why:

  • Notify issue tracking when build analysis has saved failures that need to affect current issue state. Saving failures under a build does not open or close issues by itself. A successful final analysis must send a notification even when it finds no failures, so issues left open by earlier builds can still be closed.
  • Avoid finalizing issue state from the wrong build or before its failures have been saved. Build completion can be visible before the request records which build supplied its result, so final notification waits for that decision. Failed publication is retried rather than silently losing the update, while issue analysis remains independent of the recorded validation outcome.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. No issue-tracking consumer is enabled and no schema changes are introduced; previously published notifications can remain unused.

Issue Links

Stack

  1. feat(stovepipe): Retain versioned issue state #942
  2. feat(stovepipe): Save planned issue changes #943
  3. feat(stovepipe): Apply planned issue changes #932
  4. feat(stovepipe): Track issues in bounded passes #940
  5. feat(stovepipe): Publish issue-tracking updates #939

@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from 59df37b to 49f7d42 Compare October 24, 2026 01:13
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from 49f7d42 to d84e9f5 Compare October 24, 2026 01:27
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch 2 times, most recently from c71cc78 to d7a39df Compare October 26, 2026 01:03
@prathshenoy
prathshenoy changed the base branch from codex/stovepipe-issuetrack-reconcile to codex/stovepipe-issuetrack-delivery October 26, 2026 01:04
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from d7a39df to 1775437 Compare October 26, 2026 02:26
@prathshenoy
prathshenoy added this pull request to stack #933 October 26, 2026 16:04
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from 1775437 to 2bf201a Compare October 26, 2026 18:01
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from 2bf201a to 3779370 Compare October 27, 2026 01:20
@prathshenoy
prathshenoy removed this pull request from stack #933 October 27, 2026 01:26
@prathshenoy
prathshenoy added this pull request to stack #944 October 27, 2026 01:26
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from 3779370 to a15059b Compare October 27, 2026 03:02
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch 2 times, most recently from 73c11ce to f162013 Compare October 27, 2026 03:24
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-issuetrack-publish branch from f162013 to 9728179 Compare October 27, 2026 03:38
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 27, 2026
## Summary

**What**:

- Persist queue-scoped source ordering, reconciliation ownership, and
exclusive issue cursors with guarded progress updates.
- Keep storage point-keyed and leave runtime writers disabled.

**Why**:

- Resume interrupted batches without restarting their scans or losing
the boundary after the last open issue disappears.
- Distinguish the notification that owns a pass from another
notification helping finish it.

## Test Plan

- [x] Add unit tests.
- [x] Verify checkpoint persistence, queue isolation, identifier
boundaries, and competing guarded updates against MySQL.

## Revert Plan

- Revert dependents first, then this PR. No runtime writer is enabled;
the additive progress table can remain unused.

## Issue Links

- [CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis)

## Stack

1. uber#930
1. uber#932
1. uber#940
1. uber#939
@prathshenoy
prathshenoy removed this pull request from stack #944 October 27, 2026 15:45
@prathshenoy
prathshenoy added this pull request to stack #981 October 29, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant