Skip to content

feat(stovepipe): wire queue enablement control into ingest RPC - #959

Merged
mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-ingest-enablement
Oct 28, 2026
Merged

mnoah1 merged 1 commit into
mainfrom
mnoah1/stovepipe-ingest-enablement

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Why?

  • In PR feat(stovepipe): define queue status API and RFC #854 we added the ability to track stovepipe enablement/disablement based on a commit range. This allows consumers to know whether a given commit is expected to be part of a stovepipe validation range (and thus, wait for stovepipe to include it in a range instead of deploying immediately).
  • We don't currently have a place to trigger this. This adds it as an additional field on the Ingest rpc - when included, the queue will be updated with a transition for the enablement/disablement status. Including it here insures we have a durable transition, as opposed to a more feature flag like behavior that we expect for pauses/other forms of gating.

What?

  • Accept ENABLED or DISABLED and return the applied or observed enablement status with the request ID. Omitted/UNKNOWN preserves state; repeated settings preserve the original boundary and version.
  • Record a changed setting at the same captured commit URI used for the validation request, using the existing queue state, history, and summary stores.

Test Plan

  • Bazel tests for Stovepipe, server handlers/mappers, MySQL integration, end-to-end behavior, and generated web API bindings.
  • Repository lint, mock generation, dependency, and build-file checks.

@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-ingest-enablement branch from 55aeba0 to 1d03c11 Compare October 27, 2026 21:15
@mnoah1
mnoah1 marked this pull request as ready for review October 27, 2026 21:28
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 27, 2026 21:28
Comment thread doc/rfc/stovepipe/queue-state.md Outdated
Summary:
Wire the existing queue enablement state and history into Ingest so callers can record the commit boundaries consumed by GetQueueStatus.

Accept ENABLED or DISABLED and return applied or observed enablement status with the request ID. Omitted/UNKNOWN preserves state; repeated settings preserve the boundary and version. Changed settings use the same captured commit URI as the validation request.

Enablement remains independent of pause and does not block ingestion or processing. Recording is prospective and uses the existing queue state, history, and summary stores.

Test Plan:
Bazel tests for Stovepipe, server handlers/mappers, MySQL integration, end-to-end behavior, and generated web API bindings. Repository lint, mock generation, dependency, and build-file checks.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-ingest-enablement branch from 56534ae to 8cc5563 Compare October 28, 2026 02:20
@mnoah1
mnoah1 enabled auto-merge October 28, 2026 02:20
@mnoah1
mnoah1 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 0edea98 Oct 28, 2026
36 of 38 checks passed
@mnoah1
mnoah1 deleted the mnoah1/stovepipe-ingest-enablement branch October 28, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants