chore(phone): Remove Mapperly-generated code quality errors - #335
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 44.66% 44.66%
=======================================
Files 1067 1067
Lines 51985 51985
Branches 6129 6129
=======================================
Hits 23217 23217
Misses 27792 27792
Partials 976 976
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Ah, CodeQL was looking at generated code? Can we set up CodeQL to ignore that folder? |
Contributor
Author
It appears not - this seems to be the same issue documented at 3b077f96d#diff-3c168dbb160e6a97e58e9babfc08dcd60f89cf2c81ff592398940c29e576b870R6. I can push through this change or just dismiss the findings - either works. |
rlorenzo
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL flagged 5 cs/missed-ternary-operator errors (779-783), generated by Mapperly code at web/obj/Debug/net10.0/generated/Riok.Mapperly/Riok.Mapperly.MapperGenerator/PersonnelMapper.g.cs, introduced as part of #323.
While this code is not committed as part of the repository, it can be removed by allowing DTO mappers to accept
nullif they are called as part of nested mappings that are nullable. This simplifies the generated code with no impact to the output, since Mapperly would already treat the output asnullin this case, and the methods in question are private.