Skip to content

Allow pdb to be used in pytest - #4578

Merged
timothy-nunn merged 1 commit into
ukaea:mainfrom
je-cook:allow_pdb_in_test
Sep 4, 2026
Merged

Allow pdb to be used in pytest#4578
timothy-nunn merged 1 commit into
ukaea:mainfrom
je-cook:allow_pdb_in_test

Conversation

@je-cook

@je-cook je-cook commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

CliRunner catches all errors by default. Now it only catches sys exit. This means that --pdb now works as expected for pytest args -s still doesnt function the same but now we return the result object which has captured stdout and stderror on it. This doesnt effect capsys etc as they already accomodate that.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook
je-cook requested a review from a team as a code owner September 3, 2026 12:47
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.88%. Comparing base (bd5e644) to head (7c12933).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4578      +/-   ##
==========================================
+ Coverage   49.85%   49.88%   +0.03%     
==========================================
  Files         151      151              
  Lines       29875    29871       -4     
==========================================
+ Hits        14894    14901       +7     
+ Misses      14981    14970      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook je-cook added the Testing label Sep 3, 2026
@timothy-nunn
timothy-nunn enabled auto-merge (squash) September 4, 2026 09:28
@timothy-nunn
timothy-nunn merged commit 84343f5 into ukaea:main Sep 4, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants