Repository navigation
Do not rewrite args for an unmatched default command - #2547
Open
joshbarros wants to merge 1 commit into
Open
joshbarros wants to merge 1 commit into
joshbarros wants to merge 1 commit into
Conversation
When DefaultCommand names a subcommand that does not exist, the root command still replaced parsedArgs with the default-command-prefixed slice, so the root Action received a positional argument the user never typed. Only rewrite the args when Command() actually resolves the default command. Adds a regression test for a typo in DefaultCommand.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2544
When
DefaultCommandnames a subcommand that doesn't exist,command_run.gostill replacedcmd.parsedArgswith the default-command-prefixed slice, so the rootActionreceived a positional argument the user never typed. The rewrite now only happens whencmd.Command()resolves the default command.Adds a regression test with a typo in
DefaultCommand; it fails without the change.Validation:
go test ./...passes.