Repository navigation
Conversation
|
GNU testsuite comparison: |
|
hi, this one can't be merged as it is: the build or the tests fail; it needs a rebase |
|
oke |
66bf029 to
3018635
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This adds support for POSIX locale extension modifiers: - E modifiers (%EY, %Ey, %EC, %EB) for alternative representations using ICU calendar conversions for non-Gregorian calendars - O modifiers (%Od, %Om, etc.) - falls back to standard numerals (full alternative numeric system support deferred to future work) The implementation uses ICU4X libraries for calendar conversions and localized month names. Also fix clippy warning in uptime.rs for numeric literal separators. Fixes uutils#10958
3018635 to
f88aa39
Compare
Merging this PR will degrade performance by 6.91%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | file_tz_abbreviations |
18.9 ms | 20.3 ms | -6.93% |
| ❌ | Simulation | file_iso_dates |
18.9 ms | 20.4 ms | -6.89% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing naoNao89:date-eo-modifiers (c5c9326) with main (6ef5fe8)2
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(df66079) during the generation of this report, so 6ef5fe8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
GNU testsuite comparison: |
This adds support for POSIX locale extension modifiers:
Implemented via ICU integration for calendar conversions and localized month names.
Note: Full alternative numeric system support (Arabic-Indic digits, Devanagari, blabla...) is deferred to a future enhancement as it requires ICU FixedDecimalFormatter integration
ref:
Fixes #10958