Repository navigation
Conversation
|
GNU testsuite comparison: |
xtqqczze
force-pushed
the
clippy-workspace
branch
2 times, most recently
from
April 9, 2026 11:42
ff74940 to
c807908
Compare
|
GNU testsuite comparison: |
xtqqczze
force-pushed
the
clippy-workspace
branch
from
April 9, 2026 12:25
c807908 to
765731f
Compare
|
GNU testsuite comparison: |
xtqqczze
marked this pull request as draft
April 9, 2026 13:41
xtqqczze
force-pushed
the
clippy-workspace
branch
from
April 12, 2026 00:16
765731f to
330d987
Compare
|
GNU testsuite comparison: |
Contributor
|
still draft after a few months, please reopen when ready |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
clippy-workspace
branch
from
August 27, 2026 13:41
330d987 to
1d95f3c
Compare
|
GNU testsuite comparison: |
Collaborator
Author
$ cargo clippy --features feat_os_windows --workspace --all-targets --tests --benches -pcoreutils -puucore -puu_arch -puu_b2sum -puu_base32 -puu_base64 -puu_basename -puu_basenc -puu_cat -puu_cksum -puu_comm -puu_cp -puu_csplit -puu_cut -puu_date -puu_dd -puu_df -puu_dir -puu_dircolors -puu_dirname -puu_du -puu_echo -puu_env -puu_expand -puu_expr -puu_factor -puu_false -puu_fmt -puu_fold -puu_head -puu_hostid -puu_hostname -puu_join -puu_kill -puu_link -puu_ln -puu_ls -puu_md5sum -puu_mkdir -puu_mktemp -puu_more -puu_mv -puu_nice -puu_nl -puu_nohup -puu_nproc -puu_numfmt -puu_od -puu_paste -puu_pathchk -puu_pr -puu_printenv -puu_printf -puu_ptx -puu_pwd -puu_readlink -puu_realpath -puu_rm -puu_rmdir -puu_seq -puu_sha1sum -puu_sha224sum -puu_sha256sum -puu_sha384sum -puu_sha512sum -puu_shred -puu_shuf -puu_sleep -puu_sort -puu_split -puu_stdbuf -puu_sum -puu_sync -puu_tac -puu_tail -puu_tee -puu_test -puu_timeout -puu_touch -puu_tr -puu_true -puu_truncate -puu_tsort -puu_tty -puu_uname -puu_unexpand -puu_uniq -puu_unlink -puu_uptime -puu_vdir -puu_wc -puu_whoami -puu_yes -- -D warnings
Compiling coreutils v0.13.0 (D:\a\coreutils\coreutils)
Checking uu_mknod v0.13.0 (D:\a\coreutils\coreutils\src\uu\mknod)
Checking uu_chroot v0.13.0 (D:\a\coreutils\coreutils\src\uu\chroot)
Checking uu_who v0.13.0 (D:\a\coreutils\coreutils\src\uu\who)
error[E0433]: cannot find `sys` in `nix`
--> src\uu\mknod\src\mknod.rs:10:10
|
10 | use nix::sys::stat::{Mode, SFlag, dev_t, mknod as nix_mknod};
| ^^^ could not find `sys` in `nix`
error[E0433]: cannot find `unix` in `os`
--> src\uu\chroot\src\chroot.rs:14:14
|
14 | use std::os::unix::process::CommandExt;
| ^^^^ could not find `unix` in `os`
error[E0432]: unresolved import `nix::libc`
--> src\uu\mknod\src\mknod.rs:9:10
|
9 | use nix::libc::{S_IRGRP, S_IROTH, S_IRUSR, S_IWGRP, S_IWOTH, S_IWUSR, mode_t};
| ^^^^ could not find `libc` in `nix`
error[E0432]: unresolved import `uucore::fs::makedev`
--> src\uu\mknod\src\mknod.rs:17:5
|
17 | use uucore::fs::makedev;
| ^^^^^^^^^^^^-------
| |
| no `makedev` in `features::fs`
|
note: found an item that was configured out
--> src\uucore\src\lib\features\fs.rs:12:23
|
11 | #[cfg(all(unix, not(target_os = "haiku")))]
| ---- the item is gated here
12 | pub use libc::{major, makedev, minor};
| ^^^^^^^
error[E0432]: unresolved import `uucore::libc::S_IWGRP`
--> src\uu\who\src\platform\unix.rs:13:5
|
13 | use uucore::libc::S_IWGRP;
| ^^^^^^^^^^^^^^-------
| |
| no `S_IWGRP` in the root
error[E0433]: cannot find `unix` in `os`
--> src\uu\who\src\platform\unix.rs:21:14
|
21 | use std::os::unix::fs::MetadataExt;
| ^^^^ could not find `unix` in `os`
error[E0432]: unresolved import `uucore::utmpx`
--> src\uu\who\src\platform\unix.rs:16:13
|
16 | use uucore::utmpx::{self, UtmpxRecord, time};
| ^^^^^ could not find `utmpx` in `uucore`
|
note: found an item that was configured out
--> src\uucore\src\lib\lib.rs:155:26
|
147 | any(
| ________-
148 | | target_vendor = "apple",
149 | | target_os = "cygwin",
150 | | target_os = "freebsd",
151 | | target_os = "linux",
152 | | target_os = "netbsd"
153 | | )
| |_____- the item is gated here
154 | ))]
155 | pub use crate::features::utmpx;
| ^^^^^
error[E0432]: unresolved import `uucore::entries`
--> src\uu\chroot\src\chroot.rs:17:13
|
17 | use uucore::entries::{Locate, Passwd, grp2gid, usr2gid, usr2uid};
| ^^^^^^^ could not find `entries` in `uucore`
|
note: found an item that was configured out
--> src\uucore\src\lib\lib.rs:114:26
|
113 | #[cfg(all(unix, feature = "entries"))]
| ---- the item is gated here
114 | pub use crate::features::entries;
| ^^^^^^^
error[E0433]: cannot find `mode` in `uucore`
--> src\uu\mknod\src\mknod.rs:117:17
|
117 | uucore::mode::with_umask(0, create_node)
| ^^^^ could not find `mode` in `uucore`
|
note: found an item that was configured out
--> src\uucore\src\lib\lib.rs:111:26
|
110 | #[cfg(all(not(windows), feature = "mode"))]
| --------- the item is gated here
111 | pub use crate::features::mode;
| ^^^^
error[E0433]: cannot find `termios` in `rustix`
--> src\uu\who\src\platform\unix.rs:224:13
|
224 | rustix::termios::ttyname(std::io::stdin(), Vec::with_capacity(16))
| ^^^^^^^ could not find `termios` in `rustix`
|
note: found an item that was configured out
--> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\rustix-1.1.5\src\lib.rs:298:9
|
295 | #[cfg(not(any(windows, target_os = "horizon", target_os = "vita")))]
| --------------------------------------------------------- the item is gated here
...
298 | pub mod termios;
| ^^^^^^^
error[E0432]: unresolved imports `uucore::libc::setgid`, `uucore::libc::setgroups`, `uucore::libc::setuid`
--> src\uu\chroot\src\chroot.rs:20:26
|
20 | use uucore::libc::{self, setgid, setgroups, setuid};
| ^^^^^^ ^^^^^^^^^ ^^^^^^ no `setuid` in the root
| | |
| | no `setgroups` in the root
| no `setgid` in the root
|
help: a similar name exists in the module
|
20 - use uucore::libc::{self, setgid, setgroups, setuid};
20 + use uucore::libc::{self, getpid, setgroups, setuid};
|
help: a similar name exists in the module
|
20 - use uucore::libc::{self, setgid, setgroups, setuid};
20 + use uucore::libc::{self, setgid, setgroups, getpid};
|
error[E0433]: cannot find `mode` in `uucore`
--> src\uu\mknod\src\mknod.rs:161:25
|
161 | uucore::mode::parse_chmod(MODE_RW_UGO, str_mode, true, uucore::mode::get_umask())
| ^^^^ could not find `mode` in `uucore`
|
note: found an item that was configured out
--> src\uucore\src\lib\lib.rs:111:26
|
110 | #[cfg(all(not(windows), feature = "mode"))]
| --------- the item is gated here
111 | pub use crate::features::mode;
| ^^^^
error[E0433]: cannot find `mode` in `uucore`
--> src\uu\mknod\src\mknod.rs:161:80
|
161 | uucore::mode::parse_chmod(MODE_RW_UGO, str_mode, true, uucore::mode::get_umask())
| ^^^^ could not find `mode` in `uucore`
|
note: found an item that was configured out
--> src\uucore\src\lib\lib.rs:111:26
|
110 | #[cfg(all(not(windows), feature = "mode"))]
| --------- the item is gated here
111 | pub use crate::features::mode;
| ^^^^
Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `uu_mknod` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...
error[E0433]: cannot find `process` in `rustix`
--> src\uu\chroot\src\chroot.rs:435:13
|
435 | rustix::process::chroot(target)
| ^^^^^^^ could not find `process` in `rustix`
|
note: found an item that was configured out
--> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\rustix-1.1.5\src\lib.rs:266:9
|
263 | #[cfg(not(windows))]
| --------- the item is gated here
...
266 | pub mod process;
| ^^^^^^^
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\error.rs:47:28
|
47 | NoGroupSpecified(libc::uid_t),
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:272:44
|
272 | fn name_to_uid(name: &str) -> Result<libc::uid_t, ChrootError> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:276:28
|
276 | .parse::<libc::uid_t>()
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `gid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:286:44
|
286 | fn name_to_gid(name: &str) -> Result<libc::gid_t, ChrootError> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `gid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:290:28
|
290 | .parse::<libc::gid_t>()
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:300:33
|
300 | fn supplemental_gids(uid: libc::uid_t) -> Vec<libc::gid_t> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `gid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:300:53
|
300 | fn supplemental_gids(uid: libc::uid_t) -> Vec<libc::gid_t> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `gid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:308:40
|
308 | fn set_supplemental_gids(gids: &[libc::gid_t]) -> std::io::Result<()> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find value `n` in this scope
--> src\uu\chroot\src\chroot.rs:319:34
|
319 | let err = unsafe { setgroups(n, gids.as_ptr()) };
| ^ not found in this scope
error[E0425]: cannot find type `gid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:328:23
|
328 | fn set_gid(gid: libc::gid_t) -> std::io::Result<()> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:338:23
|
338 | fn set_uid(uid: libc::uid_t) -> std::io::Result<()> {
| ^^^^^ not found in `libc`
error[E0425]: cannot find type `uid_t` in crate `libc`
--> src\uu\chroot\src\chroot.rs:355:19
|
355 | FromUID(libc::uid_t, bool),
| ^^^^^ not found in `libc`
error[E0599]: no method named `mode` found for struct `std::fs::Metadata` in the current scope
--> src\uu\who\src\platform\unix.rs:391:37
|
391 | let state = if meta.mode() & iwgrp == 0 { '-' } else { '+' };
| ^^^^
|
help: there is a method `modified` with a similar name
|
391 - let state = if meta.mode() & iwgrp == 0 { '-' } else { '+' };
391 + let state = if meta.modified() & iwgrp == 0 { '-' } else { '+' };
|
error[E0599]: no method named `atime` found for struct `std::fs::Metadata` in the current scope
--> src\uu\who\src\platform\unix.rs:392:30
|
392 | (state, meta.atime())
| ^^^^^
|
help: there is a method `accessed` with a similar name
|
392 - (state, meta.atime())
392 + (state, meta.accessed())
|
Some errors have detailed explanations: E0432, E0433, E0599.
error: could not compile `uu_who` (lib) due to 6 previous errors
error[E0599]: no method named `exec` found for mutable reference `&mut std::process::Command` in the current scope
--> src\uu\chroot\src\chroot.rs:213:66
|
213 | let err = process::Command::new(&chroot_command).args(&args).exec();
| ^^^^ method not found in `&mut std::process::Command`
Some errors have detailed explanations: E0425, E0432, E0433, E0599.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `uu_chroot` (lib) due to 17 previous errors
|
xtqqczze
force-pushed
the
clippy-workspace
branch
from
September 18, 2026 16:37
1d95f3c to
136688d
Compare
xtqqczze
force-pushed
the
clippy-workspace
branch
from
September 25, 2026 16:56
136688d to
323ca6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
clippy-workspace
branch
from
October 22, 2026 14:42
323ca6a to
66d005e
Compare
xtqqczze
force-pushed
the
clippy-workspace
branch
from
October 22, 2026 21:02
66d005e to
d9b4b06
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14911.
Blocked by #14912.
Depends on #12317.