Skip to content

fix(build): support -Zminimal-versions - #14518

Closed
xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:minver2
Closed

xtqqczze wants to merge 2 commits into
uutils:mainfrom
xtqqczze:minver2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #14919.
Depends on #11330.
Depends on ferrilab/bitvec#301.

@codspeed

codspeed Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.28%

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 386 untouched benchmarks
⏩ 54 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation three_39_bit_primes 467.5 ms 934.3 ms -49.96%
⚡ Simulation five_38_bit_primes 1.8 s 1.5 s +22.38%
⚡ Simulation thirteen_39_bit_primes 9.2 s 8.6 s +6.5%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:minver2 (bc28bb8) with main (4af0c3c)2

Open in CodSpeed

Footnotes

  1. 54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (9a7873d) during the generation of this report, so 4af0c3c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze

This comment was marked as outdated.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@xtqqczze

This comment was marked as outdated.

@xtqqczze xtqqczze changed the title NOMERGE: Fix the build with -Zminimal-versions Fix the build with -Zminimal-versions Sep 12, 2026
@xtqqczze
xtqqczze force-pushed the minver2 branch 3 times, most recently from eb3a0d5 to 7531327 Compare September 15, 2026 03:18
@xtqqczze xtqqczze changed the title Fix the build with -Zminimal-versions fix(build): support -Zminimal-versions Sep 15, 2026
@xtqqczze
xtqqczze force-pushed the minver2 branch 3 times, most recently from dedbd1d to 4fcd13e Compare September 16, 2026 09:57
Fix the build with Cargo’s [`direct-minimal-versions`](https://doc.rust-lang.org/cargo/reference/unstable.html#direct-minimal-versions) feature.

```sh
cargo minimal-versions check --quiet --workspace --all-targets --all-features --direct --workspace-behavior=cargo --target aarch64-apple-darwin
```
Fix the build with Cargo’s [`minimal-versions`](https://doc.rust-lang.org/cargo/reference/unstable.html#minimal-versions) feature.

```sh
cargo minimal-versions check --quiet --workspace --all-targets --all-features --workspace-behavior=cargo --target aarch64-apple-darwin
```
@xtqqczze

xtqqczze commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

Depends on #11330, closing.

@xtqqczze xtqqczze closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: support minimal versions

1 participant