Repository navigation
tests: fix xattr build errors - #14738
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
xattr-cfg
branch
2 times, most recently
from
September 20, 2026 12:18
894d7fc to
95ca386
Compare
sylvestre
reviewed
Sep 24, 2026
| #[cfg(all( | ||
| unix, | ||
| not(any(target_vendor = "apple", target_os = "android", target_os = "openbsd")) | ||
| #[cfg(any( |
Contributor
There was a problem hiding this comment.
same os list copy-pasted in 5 places now, could we use a cfg alias (cfg_aliases in build.rs) instead?
Collaborator
Author
There was a problem hiding this comment.
I would like to do something with cfg_aliases eventually, #11016 was my last attempt.
sylvestre
reviewed
Sep 24, 2026
sylvestre
enabled auto-merge (rebase)
September 25, 2026 12:22
auto-merge was automatically disabled
September 26, 2026 12:51
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14652.