[abendrothj]

Map the timespec time fields for AIX and Hurd inside the existing MetadataExt accessors, and gate safe_traversal and its users on Redox only, where nix has none of the *at calls.

With AIX on the safe_traversal path, chmod's AIX-only path-based symlink handling is no longer used and is removed: handle_symlink_during_traversal and its wrapper handle_symlink_during_recursion. If safe_traversal can't be brought to some other platform later, they are in this commit to restore from. The target-specific safe-traversal features of chmod, chown and install are also dropped, since perms already enables it.

Cross-checked with -Zbuild-std clippy for x86_64-unknown-hurd-gnu and i686-unknown-hurd-gnu; not run on Hurd. AIX (powerpc64-ibm-aix) doesn't build with libc 0.2.190 on main either (#15083); with libc pinned to 0.2.189 locally, uucore's safe_traversal builds. uu_du still fails to build on Hurd in fsext, as it does on main.

Closes #15028

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codspeed]

Merging this PR will degrade performance by 21.4%

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 393 untouched benchmarks
🆕 2 new benchmarks
⏩ 54 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	three_39_bit_primes	228.6 ms	694.2 ms	-67.07%
⚡	Simulation	thirteen_39_bit_primes	9.2 s	8.7 s	+6.1%
⚡	Simulation	du_wide_tree[(5000, 500)]	15.9 ms	15.2 ms	+4.7%
⚡	Simulation	tr_single_char_replace	14.5 ms	13.9 ms	+4.36%
🆕	Memory	tr_delete_single_char	N/A	35.4 KB	N/A
🆕	Simulation	tr_delete_single_char	N/A	103.9 ms	N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing abendrothj:safe-traversal-aix-hurd (85d3e76) with main (968853a)²}

Footnotes

1. 54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (ded92e1) during the generation of this report, so 968853a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[xtqqczze]

Please note the removal of the fallback path handle_symlink_during_traversal in the description, in case we ever need it to implement safe_traversal for additional platforms.

[abendrothj]

Added to the description.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[abendrothj]

Yes, with libc 0.2.190 nix fails in statvfs.rs (fsid_t vs u64) before it reaches uucore, on main as well as here. With libc pinned to 0.2.189 locally, uucore's safe_traversal builds for AIX; I left the lockfile as it is on main. I'd keep AIX in, since it shares the code with Hurd and lets chmod drop its AIX-only path, so it builds once #15083 is sorted out. I can make this Hurd-only if you'd prefer.

[sylvestre]

Thanks for your PR

[xtqqczze]

now libc v0.2.191 is released, compilation succeeds for AIX targets:

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std -p uucore --features=safe-traversal --all-targets --target powerpc64-ibm-aix