Repository navigation
Conversation
Contributor
|
I don't like this since people can just scrool. But let's see maintainer's thought. |
sylvestre
reviewed
Oct 19, 2026
| ) -> io::Result<String> { | ||
| let content = if let Some(f) = get_zip_content(archive, &format!("pages/common/{name}.md")) { | ||
| // Prefer GNU-specific examples over generic POSIX examples. | ||
| let content = if let Some(f) = get_zip_content(archive, &format!("pages/linux/{name}.md")) { |
Contributor
There was a problem hiding this comment.
did you check the utils where the linux page is for another implementation (procps uptime, net-tools hostname, util-linux more)?
they could now show examples for options we don't support
sylvestre
reviewed
Oct 19, 2026
| let mut archive = ZipArchive::new(zip.finish().unwrap()).unwrap(); | ||
| let output = write_zip_examples(&mut archive, "head", markdown).unwrap(); | ||
| assert!(output.contains(&format!("{expected} example:")), "{output}"); | ||
| if platforms.len() > 1 { |
Contributor
There was a problem hiding this comment.
why only when there are 2 platforms? asserting the other platform is absent would work for every case
limadog9
force-pushed
the
fix/uudoc-prefer-linux-tldr
branch
from
October 19, 2026 20:30
0b1e58c to
903ef3a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer Linux tldr pages for GNU-specific examples, falling back to common pages when no Linux page exists. Add regression coverage for both Markdown and manpage output.
Closes #7609.