Repository navigation
tac: accept a separator that starts with '-' - #15498
Merged
Merged
Conversation
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tac -s -1andtac --separator -1failed withunexpected argument '-1' found, while GNU tac uses-1as the separator. The separator argument now accepts values starting with-(allow_hyphen_values(true)), the same fix as #15345 forcut --output-delimiter.Fixes #15497
Test plan
test_separator_starting_with_hyphencovers-s -1,--separator -1and--separator=-1; it fails without the change and passes with itcargo test --no-default-features --features tac test_tac::: 34 passedcargo fmt --check,cargo clippy -p uu_tac --all-targets -- -D warningsFound with behave.