Skip to content

uucore: support process feature on Dragonfly BSD - #15531

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:build/uucore-process-dragonfly
Oct 20, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:build/uucore-process-dragonfly

Conversation

@xtqqczze

Copy link
Copy Markdown
Collaborator
RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std -p uucore --all-targets --features process --target=x86_64-unknown-dragonfly

@codspeed

codspeed Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.78%

⚠️ 118 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 399 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation true_consecutive_calls 294.7 ns 350.2 ns -15.86%
⚡ ⚠️ Simulation du_deep_tree[(100, 3)] 1.9 ms 1.9 ms +3.29%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:build/uucore-process-dragonfly (e032ac4) with main (6f60c70)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (48f2a33) during the generation of this report, so 6f60c70 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

/// realtime clock extensions.
#[cfg(any(
target_vendor = "apple",
target_os = "dragonfly",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dragonfly has timer_create afaik, is it just missing from the libc crate? if so, please say it in a short comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, and opened an issue: rust-lang/libc#5649

```sh
RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std -p uucore --all-targets --features process --target=x86_64-unknown-dragonfly
```
@xtqqczze
xtqqczze force-pushed the build/uucore-process-dragonfly branch from 62fd9d7 to e032ac4 Compare October 19, 2026 19:55
@cakebaker
cakebaker merged commit 9a8223b into uutils:main Oct 20, 2026
190 of 192 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants