Repository navigation
nl: keep numeric-looking file names verbatim in errors - #15544
Merged
Merged
Conversation
Windows quotes names such as 007 and 1e3 in messages, so the expected output differs there.
Contributor
|
Thanks! |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #15533
nlpassed the directory name totranslate!, which hands number-like arguments to Fluent as numbers, so a directory called007,1e3,2.50or+5was reported reformatted:This switches the
nl-error-is-directorycall totranslate_text!, as in #15534 (tail) and #15541 (tac). The othernlerrors don't go throughtranslate!with a file name, so they were already fine. The new test fails on main and passes with the change; output now matches GNU 9.12 for007,1e3,2.50and+5.Found with behave, which recorded GNU's behaviour and replayed it against uutils.