Improve the `stty --all` output to match GNU version by 3v1n0 · Pull Request #9432 · uutils/coreutils

3v1n0 · 2025-11-21T03:39:22Z

The output of stty --all was not really matching GNU one, adjust it to follow the same logic

Before:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 00:38:42.324215733 +0100
@@ -1,10 +1,6 @@
-speed 38400 baud; rows 57; columns 112; line = 0;
-intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
-eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
-werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
--parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
--ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+speed 38400 baud; rows 57; columns 115; line = 0;
+intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>; eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
+-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts 
+-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl -ixoff -tandem ixon -ixany -imaxbel iutf8 
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0 
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl echoke -flusho -extpro```

After:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 04:31:16.511313289 +0100
@@ -4,7 +4,7 @@
 werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
 -parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
 -ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+-ixany -imaxbel iutf8
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl
+echoke -flusho -extproc

Highlight is not great for word diffing, but well:

❯ wdiff /tmp/stty-out /tmp/rstty-out 
speed 38400 baud; rows 57; columns 112; line = 0;
intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
[--iuclc-]
-ixany -imaxbel iutf8
opost -olcuc -ocrnl onlcr -onocr -onlret [--ofill-] -ofdel nl0 cr0 tab0 bs0 vt0 ff0
isig icanon iexten echo echoe echok -echonl -noflsh [--xcase-] -tostop -echoprt echoctl
echoke -flusho -extpro

After the flags we're missing will be included upstream, the diff will be actually none.

github-actions · 2025-11-21T05:59:56Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T06:33:32Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T07:14:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

github-actions · 2025-11-21T07:48:56Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

ChrisDryden · 2025-11-21T18:49:39Z

+    // Status character
+    // ("status", S::VSTATUS), // Not supported by nix
+    // Minimum number of characters for noncanonical read.
+    // ("min", S::VMIN),


Is it possible that the nix compatibility is more about the platform that it is being built on?

I checked the code, but there are no such definitions... I wanted to submit a change there too, but I'm unsure about what platforms are supported, so I'd rather wait for someone having it to support it

for this specific case, actually it was defined, but I commented this out since we use the value differently in the code

Related to: uutils/coreutils#9432

github-actions · 2025-11-21T22:55:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

Related to: uutils/coreutils#9432

github-actions · 2025-11-22T06:11:17Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

Copilot

🔵 Needs a closer look

Moderate findings remain regarding platform-condition consistency and regression-test precision.

1 open finding

Adding these entries to CONTROL_CHARS also makes them part of the sane control-character…

🧠 Review effort: Lite

3v1n0 · 2026-10-16T15:25:02Z

You can simplify cfg by custom cfg: bsd given by cfg_aliases.

Done, thanks!

Copilot

🟡 Changes recommended

Haiku-specific code currently fails with the locked nix version, and output tests do not verify formatting or flag ordering.

1 open finding

Haiku build fails due to unavailable terminal flag variants · New

1 resolved since last review

Adding these entries to CONTROL_CHARS also makes them part of the sane control-character…

🧠 Review effort: Lite

Copilot

🟡 Changes recommended

Strengthen the output test to verify signed tokens, values, and ordering.

2 open findings

🧠 Review effort: Lite

Copilot

🔵 Needs a closer look

Two moderate Haiku compatibility issues remain in stty.rs.

0 open findings

2 resolved since last review

🧠 Review effort: Lite

xtqqczze · 2026-10-16T16:28:14Z

            (S::VLNEXT, "^V"),
+            #[cfg(not(any(target_os = "aix", target_os = "haiku")))]
            (S::VDISCARD, "^O"),
+            #[cfg(any(bsd, target_os = "aix", target_os = "illumos", target_os = "solaris"))]


Suggested change

#[cfg(any(bsd, target_os = "aix", target_os = "illumos", target_os = "solaris"))]

#[cfg(any(bsd, solarish, target_os = "aix"))]

you can make this kind of change throughout by adding the following cfg alias to src/uu/stty/build.rs:

solarish: { any(target_os = "illumos", target_os = "solaris") }

Let's also add aliases like:

freebsdlike: { any(dragonfly, freebsd) }, netbsdlike: { any(netbsd, openbsd) },

I'm not sure how many people can understand them. (But bsd including apple is already crazy).

Do we add linux_kernel only for stty?

xtqqczze · 2026-10-16T16:28:47Z


+    #[cfg(any(bsd, target_os = "aix", target_os = "illumos", target_os = "solaris"))]
+    #[test]
+    fn test_get_sane_control_char_dsusp() {


please fix cspell

Copilot

🔵 Needs a closer look

Cross-platform terminal behavior requires final human validation.

0 open findings

🧠 Review effort: Lite

oech3 · 2026-10-16T16:58:20Z

I'd like to have #15425 before this.

Copilot

🟡 Changes recommended

The NTO test assertion must be fixed or the corresponding flag support added.

1 open finding

Avoid panic when iuclc is unavailable on NTO · New

🧠 Review effort: Lite

Rather than repeating file-level `spell-checker:ignore` comments, register the stty-specific words in the shared workspace dictionary so that they are covered everywhere, as suggested in review.

nix cfg-gates some termios flags and control characters out on certain platforms, but stty referenced them unconditionally, so the crate could not be built there at all: Haiku misses VREPRINT, VLNEXT, VWERASE, VDISCARD, IMAXBEL, EXTPROC, B460800 and B921600, and AIX misses VDISCARD, VWERASE, EXTPROC, CRTSCTS and the same high baud rates. Gate the affected definitions with the same predicates nix uses, so that the crate compiles on every target where its dependencies do, as prerequisite for the Haiku support that follows.

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

Now the order is respected

Enable the remaining GNU flags that nix exposes as well (iuclc, ofill, ofdel and xcase), and list as comments the ones that are not supported by nix and libc (hup, cdtrdsr, flush) or that are handled manually (min and time), so that the lists stay in sync with GNU and it's easier to enable what will be supported in the future.

It's only supported by BSD, aix and solaris, but still available in nix. We need to define a sane default for VDSUSP (^Y)

Nix exposes the Termios line discipline field only on linux, android and haiku, so use it there and keep reading c_line through libc on redox, where nix does not provide the field. On Haiku the field is a c_char, so convert the value from u8 when setting it. See: nix-rust/nix#1802

3v1n0 · 2026-10-16T17:25:09Z

I'd like to have #15425 before this.

Ok, fair enough.

Copilot

🟡 Changes recommended

Apple-target configuration is missing, causing the added integration test to fail before exercising --all.

1 open finding

Include macOS and iOS in bsd dsusp mapping · New

1 resolved since last review

Avoid panic when iuclc is unavailable on NTO

🧠 Review effort: Lite

+    #[cfg(any(bsd, solarish, target_os = "aix"))]
+    // Sends a delayed suspend signal (SIGTSTP).
+    ("dsusp", S::VDSUSP),


xtqqczze · 2026-10-18T11:44:02Z

+    #[cfg(not(any(target_os = "redox", target_os = "aix")))]
    Flag::new("crtscts", C::CRTSCTS),
+    // Not supported by nix and libc.
+    // Flag::new("cdtrdsr", C::CDTRDSR),


CDTRDSR is not defined in POSIX termios.h, which platforms define it?

xtqqczze · 2026-10-18T11:46:27Z

    ("discard", S::VDISCARD),
+    // deprecated compat option.
+    // Not supported by nix and libc.
+    // ("flush", S::VFLUSHO),


not defined in POSIX, which platforms support it?

oech3 · 2026-10-21T11:23:22Z

-    #[cfg(not(any(target_os = "linux", target_os = "redox")))]
+    #[cfg(target_os = "redox")]
+    {
+        // nix does not expose the line discipline on Redox, so we get the


3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from b287c72 to 9c6d77f Compare November 21, 2025 06:33

3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from 46cbbc3 to b989937 Compare November 21, 2025 06:57

3v1n0 force-pushed the stty-better-printing branch from b989937 to bae055d Compare November 21, 2025 07:32

ChrisDryden reviewed Nov 21, 2025

View reviewed changes

Comment thread src/uu/stty/src/flags.rs Outdated

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add OFILL

87ef7ef

Related to: uutils/coreutils#9432

3v1n0 mentioned this pull request Nov 21, 2025

termios: Add OFILL nix-rust/nix#2701

Merged

1 of 3 tasks

3v1n0 force-pushed the stty-better-printing branch from bae055d to 173ad5a Compare November 21, 2025 22:04

3v1n0 commented Nov 21, 2025

View reviewed changes

Comment thread src/uu/stty/src/flags.rs Outdated

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for IUCLC

86c7019

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for XCASE

ea42111

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

This was referenced Nov 21, 2025

termios: Add definition for XCASE nix-rust/nix#2703

Merged

termios: Add definition for IUCLC nix-rust/nix#2702

Merged

3v1n0 force-pushed the stty-better-printing branch from 173ad5a to 65b5c7a Compare November 21, 2025 23:57

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

a245fc7

Related to: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

9f1304c

Related to: uutils/coreutils#9432

3v1n0 force-pushed the stty-better-printing branch 5 times, most recently from 704772b to fa39e80 Compare November 22, 2025 04:00

sylvestre force-pushed the stty-better-printing branch from f0de189 to 61ce79b Compare November 22, 2025 08:12

Copilot AI reviewed Oct 16, 2026

View reviewed changes

3v1n0 force-pushed the stty-better-printing branch from f7af8cb to 7ac48c8 Compare October 16, 2026 15:24

Copilot AI lite review requested due to automatic review settings October 16, 2026 15:24

Copilot started reviewing on behalf of 3v1n0 October 16, 2026 15:31

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread src/uu/stty/src/stty.rs

oech3 reviewed Oct 16, 2026

View reviewed changes

Comment thread src/uu/stty/src/flags.rs Outdated

Copilot AI lite review requested due to automatic review settings October 16, 2026 15:54

3v1n0 force-pushed the stty-better-printing branch from 7ac48c8 to 6868d67 Compare October 16, 2026 15:54

Copilot started reviewing on behalf of 3v1n0 October 16, 2026 15:58

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread tests/by-util/test_stty.rs Outdated

Copilot AI reviewed Oct 16, 2026

View reviewed changes

xtqqczze reviewed Oct 16, 2026

View reviewed changes

Copilot AI reviewed Oct 16, 2026

View reviewed changes

xtqqczze reviewed Oct 16, 2026

View reviewed changes

Comment thread src/uu/stty/build.rs

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread tests/by-util/test_stty.rs

3v1n0 added 7 commits October 16, 2026 17:19

stty: Move solarish and dsusp to the cspell wordlist

4edffac

Rather than repeating file-level `spell-checker:ignore` comments, register the stty-specific words in the shared workspace dictionary so that they are covered everywhere, as suggested in review.

stty/flags: Do not show tandem option

ca333be

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

stty/flags: Use same order of GNU in printing ixoff/ixon

c77f85a

Now the order is respected

stty/flags: Add delayed suspend (dsusp) support

288460c

It's only supported by BSD, aix and solaris, but still available in nix. We need to define a sane default for VDSUSP (^Y)

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread src/uu/stty/src/flags.rs

Comment on lines +393 to +395

#[cfg(any(bsd, solarish, target_os = "aix"))]

// Sends a delayed suspend signal (SIGTSTP).

("dsusp", S::VDSUSP),

xtqqczze reviewed Oct 18, 2026

View reviewed changes

oech3 reviewed Oct 21, 2026

View reviewed changes

	#[cfg(any(bsd, target_os = "aix", target_os = "illumos", target_os = "solaris"))]
	#[cfg(any(bsd, solarish, target_os = "aix"))]

Conversation

3v1n0 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

ChrisDryden Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

github-actions Bot commented Nov 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

3v1n0 commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

xtqqczze Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

oech3 commented Oct 16, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

3v1n0 commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3v1n0 commented Nov 21, 2025 •

edited

Loading

ChrisDryden Nov 21, 2025 •

edited

Loading

3v1n0 commented Oct 16, 2026 •

edited

Loading

xtqqczze Oct 16, 2026 •

edited

Loading