Repository navigation
fix(offset): accept MET, HAST and HADT like GNU date - #345
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 98.89% 98.90%
=======================================
Files 21 21
Lines 4540 4546 +6
Branches 142 142
=======================================
+ Hits 4490 4496 +6
Misses 49 49
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU date knows three zone names that are missing from the table:
parse_datetime rejects all three. Checked against GNU date 9.12 for every two- and three-letter name and every four-letter name ending in T: these are the only names GNU accepts and parse_datetime rejects.
Added
met(+1),hast(-10) andhadt(-9, daylight time, so no DST suffix) totimezone_name_to_offset, and the three rows totest_time_zone_nameswith GNU date's output, alone and with DST (HADT DSTis rejected, as in GNU).cargo test: 483 pass (test_time_zone_namesfails on main), clippy and fmt clean.