Repository navigation
Conversation
uutils#334 let weekday names take an abbreviating dot (mon., tue.), but literal_month still parsed only alpha1, so jan. 5 2024 or 14-nov.-2022 were rejected, although the module doc quotes the GNU manual allowing "an abbreviating dot" and GNU date accepts them.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 21 21
Lines 4546 4564 +18
Branches 142 142
=======================================
+ Hits 4496 4514 +18
Misses 49 49
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#334 let abbreviated weekday names take a trailing dot (
mon.), butliteral_monthstill parses onlyalpha1, so a dotted month abbreviation is rejected. The module doc ofdate.rsquotes the GNU manual: months "may be abbreviated to their first three letters, possibly followed by an abbreviating dot".This uses the same parser shape as #334 (
(alpha1, opt('.')).take()) and adds the dotted three-letter forms to the match, sosept.,june.andjanuary.stay rejected like in GNUdate. The grammar comment initems/mod.rsis updated to match.Tests: dotted rows in the
literal1/literal2/literal3tests andmonth_abbreviation_with_periodinlib.rs(all twelve months, plus the rejected forms); they fail without the change.cargo test,cargo fmt --all -- --checkandcargo clippy --all-targets -- -D warningspass locally. GNU behaviour was checked only by runningdate, not by reading its source.Written with AI assistance (Claude); I have reviewed the change.