Skip to content

[test] Remove test-buffer-bytelength-safe-fast - #266

Merged
victorgomes merged 1 commit into
v8:node-ci-2026-11-13from
gahaas:2026-11-19_remove_bytelength_safe_fast_test
Nov 19, 2026
Merged

victorgomes merged 1 commit into
v8:node-ci-2026-11-13from
gahaas:2026-11-19_remove_bytelength_safe_fast_test

Conversation

@gahaas

@gahaas gahaas commented Nov 19, 2026

Copy link
Copy Markdown

test-buffer-bytelength-safe-fast asserts that calling a Fast API function taking FastOneByteString (kSeqOneByteString) with a ConsString, SlicedString, two-byte string, or ExternalString falls back to the regular API callback without deoptimizing the caller.

FastOneByteString is only meant for call sites passing sequential one-byte strings; in https://crrev.com/c/8803935, V8 eagerly deoptimizes when a kSeqOneByteString parameter receives another string representation. Call sites expecting other string representations should accept v8::Localv8::Value instead.

Refs: https://crrev.com/c/8803935

test-buffer-bytelength-safe-fast asserts that calling a Fast API
function taking FastOneByteString (kSeqOneByteString) with a ConsString,
SlicedString, two-byte string, or ExternalString falls back to the
regular API callback without deoptimizing the caller.

FastOneByteString is only meant for call sites passing sequential
one-byte strings; in https://crrev.com/c/8803935, V8 eagerly deoptimizes
when a kSeqOneByteString parameter receives another string
representation. Call sites expecting other string representations should
accept v8::Local<v8::Value> instead.

Refs: https://crrev.com/c/8803935
@victorgomes
victorgomes merged commit 3c07a0a into v8:node-ci-2026-11-13 Nov 19, 2026
13 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants