Skip to content

[v8] Switch v8::RegExp::ExecV2 callers back to Exec - #267

Merged
pthier merged 1 commit into
v8:node-ci-2026-11-13from
backes:v8-regexp-exec
Nov 19, 2026
Merged

pthier merged 1 commit into
v8:node-ci-2026-11-13from
backes:v8-regexp-exec

Conversation

@backes

@backes backes commented Nov 19, 2026

Copy link
Copy Markdown
Member

V8 renamed RegExp::ExecV2 back to RegExp::Exec (returning MaybeLocal) and marked ExecV2 as V8_DEPRECATE_SOON in https://crrev.com/c/8794471.

Switch src/node_url_pattern.cc back to RegExp::Exec.

Refs: https://crrev.com/c/8794471

V8 renamed RegExp::ExecV2 back to RegExp::Exec (returning
MaybeLocal<Value>) and marked ExecV2 as V8_DEPRECATE_SOON in
https://crrev.com/c/8794471.

Switch src/node_url_pattern.cc back to RegExp::Exec.

Refs: https://crrev.com/c/8794471
@backes

backes commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

@pthier can you PTAL?

@pthier
pthier merged commit 3d36dba into v8:node-ci-2026-11-13 Nov 19, 2026
13 of 22 checks passed
@backes

backes commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Thanks, that was fast :D

@backes
backes deleted the v8-regexp-exec branch November 19, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants