Repository navigation
Conversation
Remove serial numbers from task-sequence logs without changing identity checks, add regression coverage, and install the selected skills. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Broken batch control flow, unsafe temporary-directory cleanup, and audit and release guidance defects remain unresolved.
8 open issues
What changed in this PR
Protects disk serials in ConfigMgr task-sequence logs while preserving identity checks, and adds development and review skills.
Changes:
- Removes serial values from inventory and pre-erase messages.
- Adds regression tests for logging privacy and serial-change rejection.
- Installs five skills and refreshes checksums.
| File | Description |
|---|---|
| Tests/Invoke-OSDDiskLayout.Tests.ps1 | Adds privacy and identity-check regressions. |
| Scripts/Invoke-OSDDiskLayout.ps1 | Removes serials from packaged-script logs. |
| Invoke-OSDDiskLayout.ps1 | Applies matching logging changes. |
| CHECKSUMS.txt | Refreshes hashes and includes new files. |
| .github/skills/pester-should-migration/SKILL.md | Adds assertion-migration guidance. |
| .github/skills/pester-should-migration/references/assertion-map.md | Documents assertion mappings. |
| .github/skills/github-release/SKILL.md | Adds release preparation guidance. |
| .github/skills/github-release/references/semver-rules.md | Documents versioning rules. |
| .github/skills/github-release/references/commit-classification.md | Adds commit-classification guidance. |
| .github/skills/github-actions-hardening/SKILL.md | Adds workflow security guidance. |
| .github/skills/github-actions-hardening/references/triggers-and-privilege.md | Explains workflow trust boundaries. |
| .github/skills/github-actions-hardening/references/supply-chain.md | Covers action and artifact security. |
| .github/skills/github-actions-hardening/references/report-format.md | Defines security-report formatting. |
| .github/skills/github-actions-hardening/references/permissions-and-tokens.md | Covers token permissions and secrets. |
| .github/skills/github-actions-hardening/references/injection.md | Documents injection prevention. |
| .github/skills/docs-sync-audit/tests/test_docs_drift.py | Adds scanner regression coverage. |
| .github/skills/docs-sync-audit/SKILL.md | Adds documentation-audit guidance. |
| .github/skills/docs-sync-audit/scripts/docs_drift.py | Implements documentation drift checks. |
| .github/skills/batch-files/SKILL.md | Adds batch scripting guidance. |
| .github/skills/batch-files/references/windows-subsystem-on-linux.md | Adds WSL resources. |
| .github/skills/batch-files/references/tools-and-resources.md | Lists Windows tooling resources. |
| .github/skills/batch-files/references/msys2.md | Adds MSYS2 references. |
| .github/skills/batch-files/references/cygwin.md | Adds Cygwin references. |
| .github/skills/batch-files/references/batch-files-and-functions.md | Documents batch scripting techniques. |
| .github/skills/batch-files/assets/task.txt | Adds an automation-task template. |
| .github/skills/batch-files/assets/library.txt | Adds a reusable-library template. |
| .github/skills/batch-files/assets/executable.txt | Adds a command-line tool template. |
Review effort: Balanced
Comment on lines
+445
to
+460
| :main | ||
| call :parse_args %* | ||
| if not defined _TARGET ( | ||
| echo ERROR: --target is required. 1>&2 | ||
| call :usage | ||
| exit /b 1 | ||
| ) | ||
| echo Processing: %_TARGET% | ||
| exit /b 0 | ||
|
|
||
| :parse_args | ||
| if "%~1"=="" exit /b 0 | ||
| if /i "%~1"=="--target" set "_TARGET=%~2" & shift | ||
| if /i "%~1"=="--help" call :usage & exit /b 0 | ||
| shift | ||
| goto :parse_args |
Comment on lines
+51
to
+53
| if "%_parOneMyTool%"=="/?" call :_showHelpMyTool & goto _removeBatchVariablesMyTool | ||
| if /i "%_parOneMyTool%"=="-h" call :_showHelpMyTool & goto _removeBatchVariablesMyTool | ||
| if /i "%_parOneMyTool%"=="--help" call :_showHelpMyTool & goto _removeBatchVariablesMyTool |
Comment on lines
+36
to
+44
| if "%_funcMyLib%"=="/?" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="-h" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="--help" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
|
|
||
| if /i "%_funcMyLib%"=="trimWhitespace" call :_trimWhitespaceMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="toLower" call :_toLowerMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="getTimestamp" call :_getTimestampMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="logMessage" call :_logMessageMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="padRight" call :_padRightMyLib & goto _removeBatchVariablesMyLib |
Comment on lines
+50
to
+52
| if "%_parOneMyTask%"=="/?" call :_showHelpMyTask & goto _removeBatchVariablesMyTask | ||
| if /i "%_parOneMyTask%"=="-h" call :_showHelpMyTask & goto _removeBatchVariablesMyTask | ||
| if /i "%_parOneMyTask%"=="--help" call :_showHelpMyTask & goto _removeBatchVariablesMyTask |
| set _checkParTwoMyTask= | ||
| REM Append new variables above this line. | ||
|
|
||
| if EXIST "%_tmpDirMyTask%" rmdir /S /Q "%_tmpDirMyTask%" >nul 2>nul |
| for /f "skip=1 tokens=* delims=" %%a in ('findstr /n "^" "%~f0"') do ( | ||
| set "_line=%%a" | ||
| setlocal EnableDelayedExpansion | ||
| set "_lineNum=!_line:~0,2!" |
| f"documents `make {target}`, which is not a target in the Makefile.", | ||
| source="Makefile") | ||
| for whole, inner in CMD_SCRIPT.findall(line): | ||
| candidate = (inner or whole).lstrip("./") |
Comment on lines
+253
to
+254
| Read the existing `CHANGELOG.md` (or create it if absent). Follow the | ||
| [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) format strictly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actions-hardening,pester-should-migration,docs-sync-audit,github-release, andbatch-files.CHECKSUMS.txt.Validation
git diff --checkpassed.