Repository navigation
Conversation
FileService.list_files no longer loads FileCodes.all() (including every text payload) and filters/sorts/paginates in Python. Status, type, health and keyword predicates are translated to SQL, ordering and offset/limit run in SQLite, and only the returned page (<=100 rows) is materialized. build_file_health_summary now uses SQL counts instead of walking every row; healthy/attention are derived from the danger/warning/success partition. Equivalence is covered by tests/test_admin_query_pushdown.py, which compares every filter/sort result against the previous per-item Python rules. 10k-row benchmark: list_files 1629ms/29.6MB -> 24.6ms/0.1MB; dashboard health summary 1483ms/29MB -> 13.8ms/<0.1MB.
|
@jcbl1 is attempting to deploy a commit to the vastsa's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
closed as stale |
1 similar comment
Contributor
Author
|
closed as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileService.list_files no longer loads FileCodes.all() (including every text payload) and filters/sorts/paginates in Python. Status, type, health and keyword predicates are translated to SQL, ordering and offset/limit run in SQLite, and only the returned page (<=100 rows) is materialized.
build_file_health_summary now uses SQL counts instead of walking every row; healthy/attention are derived from the danger/warning/success partition.
Equivalence is covered by tests/test_admin_query_pushdown.py, which compares every filter/sort result against the previous per-item Python rules.
10k-row benchmark: list_files 1629ms/29.6MB -> 24.6ms/0.1MB; dashboard health summary 1483ms/29MB -> 13.8ms/<0.1MB.