Repository navigation
Search ASCII strings from a start index without index conversion - #2362
Merged
Merged
Conversation
String.prototype.indexOf took its byte-search fast path on a proven-ASCII receiver only when the start index was not positive. A positive start went through the general path: ToIntegerOrInfinity, the surrogate-needle check, and UTF-16 to byte conversions in both directions, although byte offsets are UTF-16 indexes in an ASCII string. The fast path now covers every start index: a positive start truncates and clamps to the length, where only the empty needle is found, and the search runs from that byte offset.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexOfwith a positive start index on an ASCII string searches bytes from that offset instead of converting between UTF-16 and byte offsets.