Repository navigation
Test two inline-cache entries inline at dynamic-tier property sites - #2367
Merged
Merged
Conversation
ctate
commented
Oct 27, 2026
ctate
commented
Collaborator
- Property sites that see two object layouts (object literals of one record in two key orders) no longer call the out-of-line probe for the second layout.
- bench:runtime dynamic-properties: 16% faster (10M rounds 5.40 s -> 4.69 s on 4 vCPUs); every other workload unchanged.
A dynamic-tier property site tested only the first entry of its cache inline and called scr_js_get_probe (or scr_js_store_probe) for anything else. A site that sees two layouts, such as object literals of one record built in two key orders, then took the out-of-line probe on every access to objects of its second layout. Sites now test the first two entries inline, own or prototype, for reads and replacing writes. The probe still answers the third and fourth entries, misses and everything that is not plain data.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.