Repository navigation
fix(helm): stop Chart dependency parsing at the next top-level key - #595
Merged
Merged
Conversation
vibgrate-team
force-pushed
the
cursor/fix-helm-dependency-bounds-5651
branch
from
November 4, 2026 13:41
18802bc to
a302cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseChartYamlfounddependencies:and then ran a- name:scan over the rest of the file. The last entry's block ran to EOF. In charts whose keys are alphabetical (the usual Bitnami layout),maintainers:comes next and its- name:lines were recorded as chart dependencies. That same last block'sversion:match could also adopt the chart's own top-levelversion:.parseChartLockscanned the same way.Both parsers now stop at the first following top-level (unindented) key.
version,repository, andconditionare read only from each entry's own indented lines, so a dependency that does not declare a version stays*and never inherits the chart version. Quoted scalars are still unquoted, and atags:list inside an entry still belongs to that entry.Related issues
Closes #581
Checklist
pnpm testpassespnpm lintis cleanpnpm typecheckis cleangraph.json/ report output (content-hashed IDs, stable sorts; no time, randomness, or filesystem-order dependence)git commit -s, DCO)Notes for reviewers
test/helm-chart-dependencies.test.tscovers:Chart.yamlwithdependencies:redis20.x.x(oci://registry-1.docker.io/bitnamicharts), thenmaintainers:- name: Jane Doe, thenversion: 1.4.2. The parse and the offline scan both yield exactly one dependency, redis at20.x.x.versionof its own stays*when the chartversion:follows the list.tags:list still parse as before.Chart.lockis bounded the same way, including an entry with no version and a lock file that has nodependencies:key.