Repository navigation
fix: catalog state and the purge - #187
Merged
Merged
Conversation
The live routing suite picks its free-tier subjects from the catalog by asking the gateway, but it counted "400 Upstream request failed: Model is unavailable" as an observable answer. The upstream withdrew nemotron-3-ultra-free while the catalog still lists it, so the picker chose it and two cases asserted on a model the gateway no longer serves; the reachability case also failed on a 429 throttle. A withdrawn model (that 400, or a 410) is now skipped like a throttled one. The free-tier routing case only accepts a candidate whose answer is the free-tier gate it asserts, so an unmetered model cannot become its subject, and the reachability walk moves past gated, withdrawn and throttled candidates before it reports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The review ran three rounds through the correctness, rules and matrix lenses. What it found, and what changed: - The binary e2e's beforeAll budget was smaller than the blocking subprocess deadlines it serializes. Each plugin install now has its own deadline, the hook's budget is derived from the installs and the boot, and afterAll stops a host a failed hook left running. - providerWithApiKey claimed to be a line-for-line restatement but skipped upstream's credentialRef(ref) check. It now throws the same TypeError for a ref outside the grammar (a host-editor-contracts case pins it), and its comment names the deliberate differences. - The pinned e2e-host cell let cordis and the loader float at patch level. The overrides now force both, the cache key includes them, and the job asserts them against HOST_VERSIONS. - The pi-ai-first characterization asserted every facet under one KNOWN_DEFECT title. Each apply order now generates one test per row and facet, titled with that order's own tags. - CONTRIBUTING said the contract tests pin F11-F20, and the plan said P-T1 pins every fact. Both now give the same accounting: which facts are pinned by number, which P-R1 exercises first, and why F9 and F17 are not pinned. - CONTRIBUTING put the e2e's dummy keys in the profile's credentials file; they are in the temporary home's credentials document. - F5 had no real-host pin: host-shapes now pins that a route-level api and baseURL collapse pi's protocols onto one. F6 is recorded as first exercised by P-R1. - The credential-mapping row pinned only the api-key branch of toPiCredential. host-credentials now covers all three branches, and the env branch is asserted through pi's Models.getAuth, so the case fails without it. - The plan's reason for restating hasProviderApiKey was inaccurate; it now says no installed copy reaches the function. - The new credential cases cited toPiCredential at the wrong lines; they now cite auth.ts:74-84. - F4's listing and dispatch halves were pinned only by KNOWN_DEFECT rows P-R1 flips. A plugin-less tier-A case in host-shapes now pins that an id pi cannot place is not listed and that a turn on it is INVALID_CONFIG with no request; the save and deferred-read halves are tagged F4 too. - The one facet that depends on the apply order lost its tag when the pi-ai-first block was split. The fixture case now checks only structure (the facets whose value moves are the facets whose tag moves), and the exact pin is its own KNOWN_DEFECT case that boots no host. CONTRIBUTING and the plan say P-R1 drops todayRowsFor's override and turns that case into a BASELINE check in the same diff. Nothing under src/ changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The vendor renamed the Go plane's Gemini model from gemini-4-argon-contributor to gemini-4-argon. The tier-B fixtures (S0_PROFILE, S0_TODAY, CHARACTERIZED_PROFILE through S0, and todayRowsFor's pi-ai-first override) declared the old id as the Go gap id: one the plugin's catalog describes and pi 1.1.0 cannot place. After the refresh the catalog no longer described it. They now name the renamed id, which still plays that role because pi 1.1.0's opencode-go table has no gemini-4-argon either. The host-shapes and editor-contract cases follow the same fixture. The pi 1.3.0 note in mount-protocols names that pi's own row, so it stays as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
What the review found, and what changed: - rewrapOnAdaptersUpdated reinstalls its site inside the plugin's own teardown and on every foreign registry change. Its JSDoc in src/host/patch-method.ts now says so, counts the reinstalls a release causes, says a caller disposes it before releasing its adapters, and notes that a throw from a reinstall is logged by the host. - The plan of record said all three P-H edge changes are unreachable on the real host for one reason; the third (the live-reload listing) is unreachable for a different one. docs/improvement-plan.md now gives each its reason. - The tier-A reload cases for the listing and discovery sites proved the row only structurally. test/reload.test.ts now gives every site a tier-A probe whose decorated answer must differ from the host's own, so "survivor still decorates" and "last dispose restores" can fail. - "patchMethod is the only way the plugin wraps a host method" was asserted in docs and enforced by nothing. test/architecture.test.ts now has a textual tripwire over everything apply() reaches, with a self-check of planted violations, and the apply()-twice reload case requires a patch record on every own function apply() leaves on the stand-in. - The tripwire missed several write forms (Object.assign, Object.defineProperty/defineProperties, Reflect.setPrototypeOf, Object.setPrototypeOf, and an Object.* target reached through a property path such as registration?.adapter or this.llm). The patterns now catch them, and the self-check plants each one (17 planted, up from 13). Nothing new in src/ matches. - The docs said "any Reflect.* write" where the pattern matches a fixed set. The test docstring, AGENTS.md and the plan's P-H section now name the four Reflect and four Object methods matched, and why a prototype swap is listed. No runtime behaviour changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The refreshed Go catalog serves its Gemini model as gemini-4-argon, so the plane-dispatch mock, the plane-model cases and the binary e2e's probe expectations name the new id; the Go Google base they assert is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The review ran three rounds (found 20, 5 and 8; upheld 19, 4 and 8). What it found and what changed: - A completions model whose effort list names none lost its Off. utils/model-metadata.ts now offers Off with none as its wire value on completions, as pi 1.1.0's own entries do; Responses unchanged. Pinned in model-metadata, plane-model and a new mock-gateway case. - A Go entry with no apiKeyEnv authenticates with OPENCODE_API_KEY (pi's lookup, D20), and nothing said so. README "Changed in 1.x" and step 3 now name it; host-planes.test.ts pins both cases. - A Settings save of a plane was refused as "cannot be validated yet" while the host modules were unloaded. host/route-claim.ts now judges it with the last modules that loaded; route-claim.test.ts pins it. - Fiber.update(config) with noSave false would persist the stripped config and drop both planes. Recorded as a constraint in route-claim.ts and the plan; no caller does it today. - Stale text: cordis-context.ts comments (stream redirect, isolate, root inject), deep-dive.md (pi's Go lookup, who answers Fetch), CONTRIBUTING (field count, the host-modules floor), and historical banners on opencode-parity-plan.md and upstream-findings.md. - The mock body-shape row asserted only body.model. It now checks each protocol's required fields and that the gateway answered 200, or the vendor's 404 for the unknown id. - Route-set rows: removing the last plane now pins replace([]) on the live handle, and "booting with none" waits for the plugin's row to be active instead of sleeping 50 ms. - The live protocol-routing suite now sends paid models through the plane adapter on a tier-A host, not only raw probes. - README's credential-isolation claim was false: the Go meter can send the Zen key. README.md, README.zh-CN.md, deep-dive.md, credentials.md and redirect-planes.md now give the real order and the 403 remedies; readme-parity.test.ts keeps both READMEs in step. - The keySource hint described Automatic backwards. settings-copy.ts (en and zh) now gives literal key, captured key, then reference. - The live adapter blocks dropped a protocol whose model was withdrawn. They now walk up to three candidates per protocol (support/live-walk.ts), pass a "model is unavailable" turn only when a raw probe confirms it (support/live-probe.ts), and skip naming a protocol no candidate reached. - A mock comment claimed a body passed shape checks the mock lacks. Declined: a toggle beside an effort list still offers no Off, which moves baseline facets and needs the owner's decision; the Models store's join stays a documented restatement rather than importing a client UI package; the PR description is edited outside the tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The vendor moves its model catalog, its Go limits page and its CLI version almost daily. Each move turned every open pull request red, although none of them caused it: vendor drift is not a regression of the change under test. A pull request now fails a freshness check only when its diff changes that check's generator code: the script, every local module it loads, transitively, and the pinned version file for the CLI check. scripts/freshness-scope.ts derives those inputs from the sources and makes the call, so a new import moves them without a list to edit. Any other pull request reports drift as a warning, as a push to main already did. The offline check that every copy of the CLI version agrees with the pin still gates every pull request, since only the repository can break it. The gates fail closed: a lost scope answer gates rather than skips. The nightly run still regenerates the two tables and proposes the refresh as its own pull request, and warns on the CLI version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The vendor retired `deepseek-v4-flash` from the Zen plane (it stays on Go). This pull request changes the catalog generator's own code, so under the freshness scoping it carries the refresh itself. This takes `src/catalog-data.ts` exactly as the nightly refresh produced it (#111), with no hand edits; `src/go-limits-data.ts` did not change. It then updates the counts that still hard-code the catalog's size: - the Zen shim count in catalog.test.ts (82 -> 81); - redirect-planes.md: Zen served 82 -> 81, the no-SDK Zen cell 25 -> 24, and "0 of 82" -> "0 of 81" in the prose; - protocol-routing-and-merge.md: the per-protocol shares now read "of 81", with completions at 24; - both READMEs: the no-SDK row is 24 and the active total is 81. The Chinese table had read 27 before this change, and now matches the English one. "127 listed" is unchanged, because the vendor retires a model by marking it `status: "deprecated"`, which keeps it listed. This could not be confirmed against models.dev, which cannot be reached from here. It no-ops once main carries #111. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…-mendel-bctz9n-p1b
…-mendel-bctz9n-p2
…mendel-bctz9n-p-t1a
…nt-mendel-bctz9n-p-t1b # Conflicts: # CONTRIBUTING.md
…nt-mendel-bctz9n-p-h
The walk's fixture held the text `await import("../src/lazy.ts")`. The
test tree's own architecture gate, which starts on the next branch of
this stack, reads a dynamic `src` import anywhere in a test file's text,
including inside a string. It counted that fixture line as a test
bypassing `test/support/src.ts`, so every branch above this one failed
the gate once this pull request was merged into it.
The case is about the dynamic form, not about `src`, so the import now
names `./lazy.ts` beside the script. The walk resolves it from the
importing file's own directory, which is the same rule, and the expected
inputs follow it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…-mendel-bctz9n-p1b
…-mendel-bctz9n-p2
…mendel-bctz9n-p-t1a
…nt-mendel-bctz9n-p-t1b
…README Reverts bf1b3b8: @deepseek-ai/dsh-typert-protocol keeps >=0.2.1-alpha.1 <0.3.0 || >=0.2.2-0 <0.3.0. OC11 is met by stating the llm-pi-ai/request-headers seam's floor (0.2.2-alpha.3, 0.2.2-rc.1) in the README pair, with what a host without it does, not by the peer: - #163 deliberately kept the optional cordis peer admitting the 0.2.1 hosts' core; - D26: host gaps are feature-detected, never compared by version; - the plane adapter detects the seam by behaviour, and on a host without it the fetch patch still writes the plugin's session, origin and project headers (no turn is marked per call); only other plugins' contributors do not run on the planes there. Refusing those hosts at install buys nothing at runtime. harness-channel keeps the registry's rc.3 facts under the old range, and fetch-patch gains the OC11 case that performs that fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…6 row The P6 status row credited the owner with keeping the old typert peer range, while design item 14 records the same decision as taken for the owner. The row now says what the design item says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…recorded Design item 14's OC11 bullet said #163 "deliberately kept" the optional cordis peer admitting the 0.2.1 hosts' core. #163's record does not support the intent: it widened the peer to the 4.1 line for the rc channel, verified 0.2.2-alpha.3 and 0.2.2-rc.2 only, and left the existing 4.0.4/4.0.5 clauses in place without discussing 0.2.1. The bullet now states that fact, matching the OC11 row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Several rules were written out more than once and had started to drift. Each now has one home in src/utils/, with no behaviour change: - Route to plane: PLANE_OF_ROUTE in src/utils/planes.ts, with the exact planeOfPlaneRoute and the relay-inclusive planeForRoute, and planeForUrl beside isGoPlaneUrl. The copies in the stream hook, usage, key capture, discovery, route claim, plane provider, purge service and credentials read it. - Dollars: one formatUsd in src/utils/usd.ts with two named styles, allowance and metered, each rendering exactly as before. - Spec lookup: specOn and specFor in src/models-catalog.ts replace three inline copies; liveCatalogOn names the plane-only read. - Level names: the last capitalised copy reads effortName. - L6: src/utils/client-generation.ts records the 1.x and 2.x client generations; the plugin emulates 1.x and reads only that row. - L11: src/utils/context-windows.ts, a measured-window table shipped empty, consulted ahead of the catalog's window. - The Mistral routing rationale now cites the plugin's own rule instead of pi's catalog. Caller pins (plane table, dollar formats, level names, User-Agent, per-plane purge, credential edges, the meter's refusal per route) were green on the base and land unchanged. Source scans keep the route table and the level names from being copied again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The nightly refresh (#182) added hy4-flash-free to both planes (Zen 88 -> 89, Go 32 -> 34 with qwen4-max on @ai-sdk/anthropic) and qwen4-max to the Go limits (29 -> 30). test/catalog-docs.test.ts held five doc counts to the old catalog; the docs follow it: - README.md, README.zh-CN.md: the per-SDK routing table's no-SDK row 27 -> 28, the stated total 88 -> 89 (twice) and its date 2026-11-16; the Go plane's Chat Completions list gains hy4-flash-free and its Anthropic Messages list gains qwen4-max, so the lists stay the whole Go catalog. Kept in step for the docs-pairing gate. - docs/protocol-routing-and-merge.md: every "N of 88" becomes "of 89", the no-SDK row 27 -> 28, the count date 2026-11-16, and the refresh history names #182. - docs/redirect-planes.md: the served halves 88 -> 89 (Zen) and 32 -> 34 (Go); the shapes table's no-SDK row 27/21 -> 28/22 and Go Anthropic 5 -> 6; "0 of 89 on Zen, 0 of 34 on Go"; the Go non-completions sentence 11 -> 12; both count dates and histories name #182. The listed halves stay the ones #156 recorded, since the registry was not re-read. No test pins a count any more (the catalog tests assert invariants), the Go limits count appears in no document, and no fixture names a moved row, so no test changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The catalog refresh added hy4-flash-free and qwen4-max to Go, and the newest host cell's pi lacks both, so Settings' fetch on Go now appends them there too. Three test comments still described an empty Go gap on the newest cell; they now say what holds on every refresh. The phase record in docs/improvement-plan.md keeps its statement, marked as true at the time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The parenthetical beside the per-plane gap assertion said the newest cell's pi lacks the catalog's newest ids. Nothing asserts that, and it moves with pi's releases, so it now says only that which ids a cell's pi lacks moves with the catalog and with pi. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…claude/vigilant-mendel-bctz9n-p-t3 No file conflicted. Twelve files came in from the parent; P-T3 had touched two of them, in hunks git merged on its own: - docs/redirect-planes.md: P-T3 rewrote the section 7 paragraph on the OPENCODE_E2E_KEYED tiers (a dispatch's `keyed` input, the composite setup action); the refresh moved the section 1 and 2 counts (Zen 89, Go 34, the no-SDK row 28/22, Go Anthropic 6, Go non-completions 12) and their #182 stamp. Both kept: P-T3's paragraph, the parent's counts. - docs/improvement-plan.md: P-T3 rewrote the phase table and its own P-T3 entries; the refresh reworded one P-PD1 restack bullet (the newest cell's pi then listed every Go catalog model). Both kept. Taken from the parent unchanged, P-T3 did not touch them: README.md, README.zh-CN.md, docs/protocol-routing-and-merge.md, pnpm-workspace.yaml (vite-plus and vite-plus-core 1.6.0), pnpm-lock.yaml and channels/rc/pnpm-lock.yaml, src/catalog-data.ts and src/go-limits-data.ts (generated), test/host-discovery.test.ts, test/host-planes-foreign.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…to claude/vigilant-mendel-bctz9n-p-r3 Brings in the parent's merge of main's toolchain bump (#181: vite-plus and vite-plus-core 1.6.0, oxlint 1.93, oxfmt 0.78, both lockfiles relocked, two test helpers moved to .then().catch()) and the nightly refresh (#182: Zen 89 and Go 34 catalog models with hy4-flash-free and qwen4-max, Go limits 30), followed through the README pair, the protocol, redirect-planes and improvement-plan docs and two host tests. No conflicts. README.md, README.zh-CN.md, docs/improvement-plan.md and docs/redirect-planes.md were changed on both sides and merged cleanly in separate hunks: this branch's refusal reporting rows and plan entries beside the parent's catalog counts. The merged tree is this branch's own change (ef74a26..0f97615) applied unchanged on top of the parent (f36e849); the lockfiles and pnpm-workspace.yaml are the parent's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…to claude/vigilant-mendel-bctz9n-p5 P-R3 now carries main's #181 (vite-plus 1.5.0 -> 1.6.0, oxlint 1.93, both lockfiles relocked, two helpers moved to .then().catch()) and the #182 catalog refresh (Zen 89, Go 34, Go limits 30) with its README pair, routing and redirect-planes counts and the test subjects that moved. No conflicts. README.md, README.zh-CN.md and docs/improvement-plan.md auto-merged: P5 adds the usage-settings bullet to the README pair and its P5 rows and sections to the plan; P-R3 changes the model counts and lists in the README pair and one P-R2 restack sentence in the plan. Each side's hunks are kept as written. The merged tree is P5's own change (0f97615..6c599a5) on top of 71316be, line for line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
… claude/vigilant-mendel-bctz9n-p6 The new parent carries main's #181 (vite-plus and vite-plus-core 1.6.0, oxlint 1.93, oxfmt 0.78, both lockfiles relocked, two test helpers rewritten as .then().catch()) and the catalog refresh #182 (Zen 89, Go 34, Go limits 30 models) with its follow-through in the README pair, the protocol-routing and redirect-planes docs and two host tests. No conflicts. README.md, README.zh-CN.md, docs/improvement-plan.md, docs/redirect-planes.md and test/host-planes-foreign.test.ts merged automatically: P6 and the parent touched different hunks of each. Both lockfiles and pnpm-workspace.yaml come from the parent unchanged, since P6 changes no dependency. The merged tree is P6's own change (6c599a5..c424b21) on top of the parent, hunk for hunk; only a line offset in test/host-planes-foreign.test.ts moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
… claude/vigilant-mendel-bctz9n-p7 One file conflicted: - docs/protocol-routing-and-merge.md, the section 1 shape table: the parent recounted every row for the refresh (27 -> 28 of 89 for the default completions row, and 88 -> 89 in every denominator), while P7 relabelled the @ai-sdk/mistral row from "as pi files it" to "the plugin's own rule". Kept P7's label and took the refresh's counts, so the row reads "(the plugin's own rule) ... 1 of 89". Auto-merged without conflict, checked to differ from the parent by P7's own change only: README.md and README.zh-CN.md (P7's mistral cell beside the refresh's 89 and 2026-11-16), docs/redirect-planes.md (P7's mistral rationale beside the refresh's counts and lists), and docs/improvement-plan.md. The lockfiles and pnpm-workspace.yaml are the parent's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p6 tree (0834b63) this branch already contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Every setting now lives in one table, src/settings-table.ts: a row per key with its kind, default, choice values, volatility and card group (SETTINGS), and the host-only prose beside it (SETTING_PROSE), which the client bundle never carries. config.ts derives the schema, resolver, types, defaults and config-only list from it, settings-fields.ts the card specs, settings-copy.ts checks its copy keys against it, and a manifest test holds cordis.patch.yml's header to it by order, type label, stated default and choice values. Before, these were four hand-kept copies that could drift apart. The schema, resolver and card were pinned on the untouched tree first and land unchanged but for the named edits. Fifteen copy keys that nothing read and the meter's unused modelMarkers prop are deleted, and the zh README now names the card by the package's own title. The card says once above its controls that its settings apply when the plugin is applied again, as both READMEs do, and a real-host test performs that in both host channels. The catalog's lastError on the card is carried to P10b. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p7 tree (121bd6d) this branch already contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The three remote contracts (usage, purge, store inspection) each carried a hand-written descriptor literal, each host service a hand-written remote-methods marker, and each of the four client callers its own unwrap of the answer. Every copy differed a little. - src/contracts/remote.ts adds defineRemote, which derives each descriptor and codec from a namespace and its methods. The three contract modules move into src/contracts/, and REMOTE_CONTRACTS in src/contracts/all.ts is the one list the client mounts. - markRemote in src/host/remote.ts writes a service's marker from its contract, so the marker key has one copy and a class must implement every contract method. - src/settings-remote.ts gains findRemoteCall, unwrapRemote and callRemote. unwrapRemote is the one unwrap of all four callers; the purge and store rows go through callRemote, and the settings summary and the meter keep their arity retry between the find and the unwrap. Caller return types are unchanged, so no rendering module changes. - isGoUsage is deleted; USAGE_NAMESPACE and parseUsageReading (a superset of the vendor whitelist that keeps the fields the service attaches) are added. - remote-contract reads the contracts and the mounted services instead of matching source text. The differences that remain are on answer shapes the host's RemoteResult cannot carry, each pinned by a case: the store row shows an envelope-level message or a string error, purge no longer reads a refusal nested in a value, the summary and the meter keep the whitelisted copy of a valid reading, and a throwing remote getter on a lookup miss answers "unavailable" instead of throwing. No webServer route appeared, so the loopback guard planned for this phase is not built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p8 tree (7e54c1b) this branch already contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Phase P10a of docs/improvement-plan.md: pure module moves, with no behaviour change, and every name the test door exports keeps its signature. - The Settings discovery wrapper moves from src/models-discovery.ts to src/host/discovery.ts. - The meter's quota discovery and key resolution (src/go-discovery.ts) merge into src/credentials.ts. Its coverage floor drops just under 100 because one branch in resolveGoKeyForRef is unreachable: the credentials resolver never rejects. - src/usage-ui.ts splits into usage-css.ts, usage-time.ts, usage-state.ts and usage-copy.ts; parseFailure and UsageFailure move to src/contracts/usage.ts. - The fetch patch becomes stages under src/request/ (claim, body, credential, headers, and patch-fetch.ts composing them). callHeadersFor leaves lifecycle.ts for request/headers.ts, beside the patch's own header stage. - A claimed request's body is parsed at most once, and lazily: a request no reader needs is never parsed. The readers keep their existing string-versus-Buffer rules, pinned by tests first. Tests that pin the source layout or the CI path filter by literal follow the moves (path literals only). New cases pin the single parse and the zero-parse path. AGENTS.md's repo map, the docs and the coverage floors in vite.config.ts are updated to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p9 tree (24e627d) this branch already contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The catalog parse rewrote the module's retired-id sets as a side
effect, so any parse (a generator, an e2e file, a refresh that then
landed nothing) changed the live retirements. A refresh merged into
the old map, so an id the registry dropped or retired stayed served
forever, and it resolved only the rows, leaving the purge to read the
outcome from module state and swallowing the error.
The parse is now pure and answers each plane's retired ids. The live
catalog is one state per plane (rows and retired ids), seeded from the
shim and replaced whole, never merged, by a refresh that carries at
least one active row for that plane; a failed, empty or retired-only
read replaces nothing. refreshCatalog resolves { ok, deprecated, go,
zen } and keeps its lastError, which the card shows beside the purge
row.
The purge judges by its own refresh's answer, rewrites each entry in
one pure step, skips entries with nothing retired and writes each
changed entry at most once, instead of up to two no-op edits per
entry. The purge remote gains review() and removeUnserved(): the card
lists the declared ids pi cannot serve on owned plane entries and
removes them.
The shim generator emits OPENCODE_DEPRECATED_IDS, and the staleness
check reads the whole generated output through one reader instead of
two hand-kept lists. src/catalog-data.ts is read tolerantly until it is
regenerated with the export.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p10a tree (bbbea4b) this branch already contains. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
viztor
changed the base branch from
claude/vigilant-mendel-bctz9n-p10a
to
main
November 17, 2026 01:33
Owner
Author
|
Until then, the runtime and the scripts read the missing export as empty retired lists. The live refresh still fills them on every boot. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase P10b of docs/improvement-plan.md, stacked on #186.
What changed
src/models-catalog.ts)parseModelsDevCatalogcleared and refilled the module's retired-id sets, so any parse (a generator, an e2e file, a refresh that then landed nothing) rewrote the live retirementsdeprecated: { go, zen }, sorted) and touches no module state{ rows, deprecated }, seeded from the shim and replaced whole, never merged. A plane is replaced only when the payload carries at least one active row for it (L12); a failed, empty or retired-only read replaces nothing, and a plane's rows and retired ids always come from the same payloadrefreshCatalog{ go, zen }and swallowed its error; callers read the outcome from module state after the awaitCatalogRefresh { ok, deprecated, go, zen }and keepslastErrorwith the state (set unless both planes landed; an older attempt cannot overwrite a newer one's outcome)src/purge-service.ts)configEditor.editcalls per entry, and the declaration sweep edited every owned entry even when nothing was retired (on the real host a no-op edit still validates, rewrites the profile and reconciles)purgeEntryConfig: declarations on owned routes, then references), a pre-check that skips entries with nothing to change, oneeditper changed entry, judged by the refresh result's owndeprecatedsrc/contracts/purge.ts)purge()onlyreview()(the declared ids on owned plane entries that pi cannot serve, by pi-ai's own "needs an api" rule mirrored purely, plus the catalog'slastError) andremoveUnserved()(the same one-edit-per-entry engine with that predicate, judged per entry)lastError; nine new copy keys. Proved on the real host in tier B (a removal's next Settings edit after the handback is accepted, and its control refused in pi-ai's words)scripts/catalog-shim.ts,scripts/regenerate-catalog-shim.ts,scripts/verify-catalog.ts)OPENCODE_DEPRECATED_IDS(inserting the declaration when the file lacks it, so--writeadds it with no hand edit); staleness covers the whole generated output through one reader.src/catalog-data.tsis not touched: until it is regenerated, the runtime and the scripts read the export tolerantly (absent means empty lists)docs/deep-dive.md,docs/testing.md,AGENTS.mdllm/models-updatedis still not emitted (carried).Behaviour changes
Review
lastErrorordering, the removal-outcome sentence on mount, references removed route-wide, tests that missed their target) fixedVerification
pnpm run checkvp test runvp test run --config vitest.mock.config.tspnpm run buildscripts/check.tslib/client.js156038 bytes, under the 158720 tripwirevp test run --coverageThe first five rows were re-run on the final tree after merging the updated base, which changed no file.
Landing dependency
catalog freshnessis expected to fail: it reportssrc/catalog-data.tsstale because the committed shim lacks theOPENCODE_DEPRECATED_IDSexport the changed generator now emits (plus any registry drift since the last refresh), and it gates only because this pull request touches that check's generator inputs (D23). The regenerated shim has to come from this generator, bypnpm run catalog:shim -- --writeon a machine that reaches the registry; the nightly refresh runsmain's generator, so it brings the export only once this generator is onmain.Generated by Claude Code