Skip to content

🔒 Fix SDK and build security dependencies - #392

Merged
Robdel12 merged 2 commits into
mainfrom
rd/fix-transitive-security
Nov 2, 2026
Merged

Robdel12 merged 2 commits into
mainfrom
rd/fix-transitive-security

Conversation

@Robdel12

@Robdel12 Robdel12 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Why

The published Storybook and static-site plugins depend on serve-handler, which pins vulnerable minimatch 3.1.5. The lockfile also retains affected glob and follow-redirects versions through build tooling. Dependabot's recorded update error says it cannot resolve follow-redirects past 1.16.1, while the fix starts at 1.16.2.

Approach

Replace serve-handler with serve-static in both plugins and Vitest's development-only browser test server. This removes that minimatch dependency from the SDKs. Keep explicit HTML and asset URLs, directory indexes, HEAD requests, caching, ranges, and HTTP errors covered through real HTTP requests.

Resolve affected transitive glob versions to 14.0.2 and follow-redirects versions to 1.16.2 with targeted overrides. The existing release-age policy stays in place; no advisory is ignored or dismissed.

Evidence

The production-only workspace audit reports zero vulnerabilities. Packed archives confirm the Storybook and static-site dependencies changed, the Ember SDK depends only on playwright-core, and none of the four SDKs includes its example or test app.

All 1,910 core tests pass with six skips, all 450 JavaScript SDK tests pass, and all 38 Storybook, static-site, and Vitest browser workflow tests pass. The HTTP contracts cover assets, encoded filenames, conditional and range requests, traversal rejection, missing files, methods, and shutdown. Builds, architecture, peer compatibility, lint, formatting, and type checks pass.

Remaining Ember test-app advisory

The full development audit still reports minimatch 3, 5, and 10 exclusively through clients/ember/test-app. These are fixture dependencies, not dependencies of the published Ember SDK.

The paths run through Embroider shared-internals and Broccoli tools, Ember CLI and Testem, and EJS/Jake/filelist. Current upstream releases still require older minimatch majors. Version 11 changes the callable export, removes makeRe(), and changes parsed matchers, so forcing it globally would break consumers. A complete fixture fix needs those consumers upgraded or migrated, followed by the Ember build and browser tests; it is separate from the now-clean SDK production graph.

Resolve affected glob releases to 14.0.2 and follow-redirects to 1.16.2 across the workspace. These overrides address the remaining glob and redirect advisories while preserving older minimatch APIs still required by upstream tooling.
@vizzly-testing

This comment has been minimized.

Replace serve-handler with serve-static in the published Storybook and static-site plugins and the Vitest browser fixture. Verify real HTTP behavior and screenshot workflows, and leave the remaining incompatible minimatch consumers confined to the Ember test app.
@Robdel12 Robdel12 changed the title 🔒 Patch transitive glob and follow-redirects 🔒 Fix SDK and build security dependencies Nov 2, 2026
@vizzly-testing

vizzly-testing Bot commented Nov 2, 2026

Copy link
Copy Markdown

Vizzly - Visual Test Results

CLI Reporter - Waiting for build

No builds received yet for this pull request.

CLI TUI - Approved

5 comparisons, no changes detected.

View build


rd/fix-transitive-security · ad8e22b9

@Robdel12
Robdel12 merged commit cdc0a1b into main Nov 2, 2026
34 of 35 checks passed
@Robdel12
Robdel12 deleted the rd/fix-transitive-security branch November 2, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant