fix: repair go.mod/go.sum so local builds work (COR-13588) - #7
Open
Bradenream wants to merge 1 commit into
Open
Conversation
The generated go.mod listed a phantom require (spyzhov/ajson, imported nowhere) and omitted the transitive requires Go needs, so every local 'go build' failed with 'missing go.sum entry'. CI never noticed because goreleaser runs 'go mod tidy' in a before hook — this commit checks in exactly the module state CI already builds with.
This was referenced Aug 26, 2026
This was referenced Aug 26, 2026
There was a problem hiding this comment.
Pull request overview
Aligns the repository’s Go module requirements with the dependency graph produced by go mod tidy, so clean-checkout local builds don’t fail due to missing/incorrect module requirements.
Changes:
- Removes an unused direct
requireentry (github.com/spyzhov/ajson) that is not imported anywhere in the codebase. - Adds missing direct and indirect
requireentries (includinggithub.com/spf13/pflagandgithub.com/stretchr/testify) to match actual imports and test dependencies. - Normalizes
go.modformatting/indentation consistent with standardgo mod tidyoutput.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bradenream
changed the title
DecathectZero
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of COR-13588 — shipping the vf CLI as an agent-era distribution channel.
Problem
go buildfails from a clean checkout: the generated go.mod carries a phantom require (spyzhov/ajson— imported nowhere) and omits the transitive requires Go needs, so every local build dies withmissing go.sum entry. CI never noticed because goreleaser runsgo mod tidyin a before-hook.Fix
Commit exactly the module state CI already builds with (
go mod tidyoutput): phantom require dropped, transitive requires filled in, mixed indentation normalized.go.mod is generation-tracked; persistent edits are enabled and CI's own tidy makes any drift harmless.
Verification
go build ./...from clean checkout: passes (fails on master)go vet ./internal/...: clean