Skip to content

Reduce syscall noise in Python scan benchmarks #10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortsui20 merged 1 commit into from
Oct 29, 2026
Merged

Reduce syscall noise in Python scan benchmarks #10998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/codspeed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ jobs:
uses: CodSpeedHQ/action@78102a468f96d8e0ccb92d0ec49425753fc42062 # v5
env:
VORTEX_BENCH_DATA_DIR: ${{ runner.temp }}/vortex-bench-data
# Drive scans on the calling thread. Background workers wake every 100 ms to check
# for shutdown. Under simulation, those timer wakeups can dominate the measured work.
VORTEX_MAX_THREADS: "0"
with:
run: cd vortex-python && uv run --all-packages --no-sync pytest benchmark/ --codspeed
token: ${{ secrets.CODSPEED_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion vortex-python/benchmark/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ def vxf(
directory = os.environ.get("VORTEX_BENCH_DATA_DIR")
path = data.write(Path(directory) if directory else tmp_path_factory.getbasetemp() / "data", request.param)

return vx.open(str(path))
# Measure scan and decode CPU work without dispatching file reads to IO threads.
return vx.open(str(path), memory_map=True)
Loading