Repository navigation
Move array serde from VTable to explicit ArrayPlugin impls - #11285
Merged
Merged
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/explicit-array-plugins
branch
from
November 6, 2026 15:30
8c0c881 to
a18ed1b
Compare
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
marked this pull request as ready for review
November 6, 2026 15:57
robert3005
approved these changes
Nov 6, 2026
robert3005
left a comment
Contributor
There was a problem hiding this comment.
I shall trust that this is just a move not a semantic change
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
connortsui20
reviewed
Nov 6, 2026
Member
There was a problem hiding this comment.
Wait I thought we were going to change this back to a normal Decimal instead of DecimalPlugin
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/explicit-array-plugins
branch
from
November 6, 2026 16:12
129204e to
157921a
Compare
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
commented
Nov 6, 2026
| pub struct DecimalPlugin; | ||
|
|
||
| impl ArrayPlugin for DecimalPlugin { | ||
| impl ArrayPlugin for Decimal { |
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…gins Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
force-pushed
the
mk/explicit-array-plugins
branch
from
November 6, 2026 17:38
e9cd2a5 to
503854f
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the blanket
impl<V: VTable> ArrayPlugin for Vand theserialize/deserializemethods onVTable. Every serializable encoding now implementsArrayPluginexplicitly on its vtable type, in aplugin.rschild module next to itsimpl VTable. Redo of #10111 on current develop.Changes
VTablecovers only in-memory behaviour; serde isimpl ArrayPlugin for X.read_ids/write_idsdefault tovec![self.id()], what the blanket impl declared. Plugins with one wire ID no longer spell them out, includingALPPatchedPlugin,ScalarFnArrayPluginand the Python stub.ArrayPlugin::id(self); only theidmethod itself delegates toVTable::id.session.arrays().register(X)is unchanged for every encoding that was serializable.DecimalPlugin(Read legacy vortex.decimal nodes into the canonical array or a Widen #10995) becomesimpl ArrayPlugin for Decimal: one wire ID, same legacy-node reads, no separate type. Its module,StoredDecimaland tests stay where they are.BitPackedPlugin,FoRPlugin,DecimalBytePartsPlugin) andWidenPluginare untouched;ALPPatchedPluginnow delegates toArrayPlugin::deserialize(&ALP, ..).PythonVTablekeeps a stub plugin so the PythonregisterAPI still compiles.plugin.rschild are directory modules (array.rsbecomesarray/mod.rs, 14 pure renames). ALP's own impl andALPPatchedPluginsharealp/array/plugin.rs.ArrayPlugininstead.impl ArrayPlugin(vortex-array)impl ArrayPlugin(encodings + python)API changes
VTablelosesserializeanddeserialize. An external vtable that was registered through the blanket impl must nowimpl ArrayPluginto be registrable.ArrayPlugin::read_ids/write_idsgain defaults ofvec![self.id()].vortex_array::arrays::DecimalPluginis removed; registerDecimalinstead.Behaviour changes
PiecewiseSequenceis no longer registered byArraySession::default(); it never serialized, and its error is now "is not registered for serialization".vortex.piecewise-sequencemakes every default-session file 48 bytes smaller.test_stock_ticker_file_sizeexpectations move accordingly (70060 → 70012, 69996 → 69948, 55144 → 55096).DecimalByteParts,BitPackedandFoRcan no longer be registered bare, sobare_vtable_refuses_serdeandvtable_serde_requires_pluginare removed.Testing
cargo clippy --all-targets --all-features -- -D warningsandcargo +nightly-2026-09-10 fmt --checkon every touched crate (vortex-array, vortex-file, vortex-layout, vortex-python and the 13 encodings crates).cargo nextest runon all touched crates plus vortex-ipc and vortex-scan: 8981 passed, 0 failed;cargo test --docon vortex-array, fastlanes, decimal-byte-parts and alp.cargo nextest run -p vortex-file -E 'test(test_stock_ticker_file_size)'with and without--features zstd, to derive the new sizes.Follow-up
SerializedArray::childinstead of returning an error. Worth hoisting the count checks in a separate PR.FoRPlugin/BitPackedPlugin/DecimalBytePartsPluginintoimpl ArrayPlugin for FoRetc. if wanted.VTableonto explicitArrayPluginimpls #11298, which makes the same change with inline impls and trait defaults forread_ids/write_ids.