Repository navigation
feat: Preview a manual household task automation (#98) - #99
efraespada wants to merge 18 commits into
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on00550a0. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit cdd84ce was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- high: Recursive condition annotations reference an undefined alias —
backend/src/domus/entrypoints/automation_http.py:45
Bugbot: 1 finding needs attention
Findings |
There was a problem hiding this comment.
Current status: 1 finding originating in this review requires attention.
Last reconciled on00550a0. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit e8fd832 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Title field allows twice the supported length —
frontend/src/presentation/domus-automation-preview.ts:134
|
Installed acceptance for head
CI Check on the same head passed all application and architecture jobs, including 54 household journeys in the actual image on each architecture. The exact published SDD bytes are present on this head. Commit remains blocked by the status-card selection defect tracked in vypdev/copilot#961. |
Closes #98.
Changes
a8a28267808655f839b40e116aa8ed99c132390eand retains SQLite schema 31.Verification
0.0.0-edge.29in a disposable aarch64 Supervisor app. Verified English keyboard validation, draft retention, Spanish touch at 390 × 844, and matching and nonmatching stock conditions. No task was created; stock remained at two after the separate intake, and Family remained available. Removed the temporary app, its data and its source, restoring 14 installed apps and eight sources. Installed record.4a1c22c, including 80 loopback cases rerun with socket access. The independent audit confirmed 100% of lines and branches in all 221 authored files (17,058 statements and 4,660 branches).4a1c22cpreserves the runtime and package tested in Supervisor.3d14248extends the backend job to 25 minutes and places SQLite fixtures in the temporary directory for each job. The remote backend job passed all 5,346 tests and the 100% coverage audit.1b4dc0agives instrumented Home Assistant Core up to 120 seconds and explicitly removes the probe after an attached Docker command times out. The pinned amd64 Core case and the ARM64 Core cases passed locally. A forced amd64 timeout verified that Docker removed both the probe and its temporary network.00a7d27setsTMPDIRon the Vitest and Chromium steps. Vitest writes its coverage lock in the system temporary directory, which reportedENOSPCon Ubuntu. All three Vitest suites passed locally and on that CI run with the runner's per-job temporary directory.00a7d27, CI and Branch Sync passed. Backend passed 5,346 tests and the independent 100% coverage audit. Frontend passed 1,734 tests with 100% coverage and 109 compiled Chromium journeys. Each image architecture passed 46 container tests and 54 Chromium journeys. CI · Branch Sync.official-installer-script-exit-23-unknown). They stopped before code review and commit verification. The separate CLI diagnostic passed on Ubuntu runner 1, where the review retry still failed during provisioning. Review · Commit · CLI diagnostic.Edge.31 candidate
a8a28267808655f839b40e116aa8ed99c132390e. The ARM64 build matched all 221 Python and four UI file hashes in the artifact. The Python file hashes are identical to Edge.30. Local frontend type checks, 1,734 Chromium tests with 100% coverage globally and per authored file, production build, nine package tests and documentation checks passed.ed433dbca98fa78dbad08588291eaba812b9363d. CI · Branch Sync · Review · Commit verification.0.0.0-edge.31for the disposable904f4e29_domus_edgeapp. In Spanish at 390 × 844, blocking only the catalog request left the title and preview available and hid the empty selector. Touch preview returned a proposal. After restoring the request, touch retry restored the product selector and preserved the title. A stock condition worked with touch in Spanish and keyboard input in English. Tasks stayed empty and available stock stayed at zero. Removed the temporary app, its private data, configuration and source and verified the original app list and eight sources.official-installer-script-exit-23-unknownandconfiguration.unsupported. The actual review and commit verification have yet to run successfully on this wrapper.Rerun with the preinstalled Codex CLI
The temporary repository variable
AGENT_EXECUTABLE=codexwas used for both targeted reruns oned433dbca98fa78dbad08588291eaba812b9363dand removed after both ended.artifactsstage withagent.policy-rejected. The underlying system error was omitted from the job log. Review attempt 2.validation.evidence-unavailable. The selected publication commit remains an ancestor and the specification blob is unchanged, as recorded below. Commit attempt 2.Copilot verification
The selected specification was published in
89a65fbdafd1d99efab1c6c74459718c898160d8, an ancestor of the final head. Its blob2fc5a668d5510b13c53f28c9abda393886720d92is unchanged. The earlier Commit validation selected the separate preparation status comment as a newer gate card; the reproduction is tracked in vypdev/copilot#961.