Skip to content

Intialize timeout to 0 and replace 'is present' check with comparison - #106

Merged
shaseley merged 2 commits into
w3c:gh-pagesfrom
shaseley:fix-timeout-is-present
Nov 12, 2026
Merged

shaseley merged 2 commits into
w3c:gh-pagesfrom
shaseley:fix-timeout-is-present

Conversation

@shaseley

@shaseley shaseley commented Feb 6, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #105. This doesn't change behavior since the timeout was only used if it was present and positive.


Preview | Diff

@shaseley

shaseley commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator Author

Hey @yoavweiss, any idea why the link-checker step might be failing or if this is affecting other repos? I tested a more trivial change and have the same issue (https://github.com/w3c/requestidlecallback/pull/107/checks). I don't think there's been a change to this repo in quite a while.

@yoavweiss

Copy link
Copy Markdown
Contributor

@dontcallmedom is this a known issue with the link-checker?

@dontcallmedom

Copy link
Copy Markdown
Member

I can't find a matching bug report - I haven't noticed that issue in my own repos, but it's only because I tend to disable the link checking step as usually too flaky (but not buggy).

I suggest reporting the issue on https://github.com/w3c/spec-prod/ with cc @deniak as this may impact a number of auto-published specs.

@mmocny

mmocny commented Jul 21, 2026

Copy link
Copy Markdown

(I still see a failing check-- not sure if it just needs poking maybe?)

@mmocny mmocny left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, not sure if you want to land as-is after #106

@shaseley
shaseley force-pushed the fix-timeout-is-present branch from 9707265 to 66cb1dd Compare November 12, 2026 21:16
@shaseley

Copy link
Copy Markdown
Collaborator Author

@mmocny, yeah I'll land this now that the CI is working. Thanks!

@shaseley
shaseley merged commit 90f50d3 into w3c:gh-pages Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use default of 0 for timeout option

4 participants