docs: correct GitHub factory mention and label behavior - #659
docs: correct GitHub factory mention and label behavior#659warp-agent-staging[bot] wants to merge 4 commits into
Conversation
The GitHub factory page treated unlabeled @warp-factory mentions as ignored and named the routing label after the Foreman agent. Match the page to current warp-server behavior: factory:<alias>, default automation filters, unlabeled fallback routing, and create-time snapshots.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment    |
State the three ANDed seeded filters, describe label create/delete as asynchronous best-effort on installed user repos, derive factory:<alias> with normalization and shortening, and key fallback on accessible factories. Distinguish review-thread replies from submitted reviews.
Step 2 of mentioning a factory treated assignment as if it were written in the issue body. Mention stays in new text; assignment uses GitHub's assignee control.
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the GitHub factory integration documentation to reflect the current label, mention, assignment, and fallback routing behavior. The changes stay within the existing page structure, use valid internal anchors, and add troubleshooting detail where readers are likely to look for it.
Concerns
No blocking concerns found. The spec context file states that no approved or repository spec context was available, and the docs-only diff did not introduce security-relevant code, configuration, dependency, secret, or data-handling changes.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@warp-factory address all these comments |
|
More than one Factory you can access is connected to this repository. Apply the appropriate |
MaggieShan
added
the
factory:maggie-test
|
@warp-factory address my pr comments |
|
More than one Factory you can access is connected to this repository. Apply the appropriate |
|
@warp-factory address my pr comments |
|
On it — picking up your 8 inline comments and pushing revisions to this branch. Responding as maggie-test: Open session · View in factory |
- Drop the automation names, ANDed-filter enumeration, and per-event list from the mentions/labels flow. - Drop the best-effort/async GitHub App caveats for label create and delete; keep the underlying facts (label derived from alias, label removed on disconnect/delete, alias rename leaves old labels). - Drop the assign-as-alternative-to-mention detail. - Revert the mention-counts-as and automation-filters paragraphs toward their pre-PR concise phrasing.
|
All 8 comments are addressed in Responding as maggie-test: Open session · View in factory |
1 participant
Summary
Corrects the GitHub factory integration page so mentions, labels, and default automations match current warp-server behavior.
The page previously said unlabeled
@warp-factorymentions never start work, and it named the routing label after the Foreman agent. The label is derived asfactory:<alias>. Agents apply the label when they open or adopt issues and pull requests. Unlabeled mentions can still auto-route when the requester can access exactly one factory on the repo.Related issues
None. Requested in Slack: https://warpdev.slack.com/archives/D0BNNM4KDR7/p1787937986628719
Changes
factory:<alias>is derived from the factory's alias, not the Foreman's display name. Warp creates the label automatically when the factory is created, and removes it when you disconnect the repository or delete the factory; renaming the alias can leave an old label behind.@warp-factoryfallback: one accessible factory auto-routes, more than one accessible factory asks for a label, and no accessible factory gives access guidance. Fallback needs a linked Warp account; matching automations do not.Validation
logic/factory_labels.go,logic/factorysource/defaults/automations.go,logic/factorysource/defaults/skills/github/SKILL.md,logic/ai/ambient_agents/github_factory_routing.go,logic/ai/ambient_agents/automations/provider_github.go,logic/ai/ambient_agents/automations/markdown.go,config/github.go, plus REV-1894 and REV-1897 specs.python3 .agents/skills/check_for_broken_links/check_links.py --internal-only— 0 broken linksnpm run typecheck— 0 errorsnpm run build— succeedednpm run lint/ Trunk not installed in this environmentScreenshots
None. Copy-only change.
Follow-ups
None.
Content design plan
Unverified claims
None against warp-server. Foreman name under Settings > Identity matches existing factory dashboard docs, not a live dashboard session in this run.