Skip to content

docs: allow one-to-two-sentence frontmatter descriptions consistently - #660

Merged
rachaelrenk merged 1 commit into
mainfrom
factory/reconcile-frontmatter-description-rule
Aug 28, 2026
Merged

docs: allow one-to-two-sentence frontmatter descriptions consistently#660
rachaelrenk merged 1 commit into
mainfrom
factory/reconcile-frontmatter-description-rule

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Summary

AGENTS.md's frontmatter description rule contradicted docs/.agents/skills/draft_docs/SKILL.md:143, which already documents the correct, more permissive rule: "One to two sentences, roughly 50-160 characters, stating the user benefit and primary keywords." This inconsistency caused JAS-5's code review of PR #656 to flag an in-budget two-sentence description as a blocking finding.

This PR reconciles the rule across the repo:

  • AGENTS.md "Description rules" subsection: now allows up to two short sentences when they stay within the 50-160 character budget and genuinely improve readability/clarity, while keeping the "prefer one sentence when it earns its length" guidance.
  • AGENTS.md frontmatter YAML example and SEO section: updated to match.
  • AGENTS.md Quality checklist: "one-sentence description" → "one-to-two-sentence description".
  • Every content-type template (conceptual.md, procedural.md, quickstart.md, reference.md, feature-doc.md, guide-page.md, faq.md, troubleshooting.md) and every corresponding draft_* skill: updated the same frontmatter-description guidance for consistency.

The 50-160 character budget itself is unchanged — only the strict one-sentence-only constraint was relaxed.

Verification

This is a skill-doc/style-guide prose change with no new testable code (skill-doc-only exemption per factory-verification), so no regression test was added. Ran the repo's documented checks:

  • trunk check / trunk fmt — Trunk is not vendored in this sandbox and is not installed, so these could not be run (consistent with prior PRs in this thread).
  • python3 .agents/skills/style_lint/style_lint.py --changed — 0 files scanned (style lint targets src/content/docs/ pages; this change only touches AGENTS.md and .agents/), no issues found.
  • Verified the diff is scoped to AGENTS.md and .agents/templates/ + .agents/skills/draft_* — no unrelated files touched, and the create_pr/SKILL.md PR-body word-budget rule was left untouched as instructed.

This unblocks JAS-5 (PR #656's review), which was blocked on a two-sentence-but-in-budget frontmatter description finding.

Originating thread: https://warpdev.slack.com/archives/C09BVK0PL3Y/p1787900556500469

Reconcile AGENTS.md's frontmatter description rule with
draft_docs/SKILL.md:143, which already documented the more permissive
one-to-two-sentence guidance. Update the two contradicting spots in
AGENTS.md (Description rules, SEO section, and the quality checklist),
plus every content-type template and draft_* skill that still stated a
strict one-sentence-only rule, so the whole repo is internally
consistent. The 50-160 character budget is unchanged.

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 28, 2026
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 28, 2026 6:37pm

Request Review

@warp-agent-staging warp-agent-staging Bot added the warpy-factory Opened by the Warp factory agents label Aug 28, 2026
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review August 28, 2026 18:35
@warp-for-oss

warp-for-oss Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@warp-agent-staging[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-for-oss warp-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR reconciles the docs repository's frontmatter-description guidance so AGENTS.md, content-type templates, and draft skills all allow one to two concise sentences within the existing 50-160 character budget. The diff is scoped to prose guidance and does not add code, tests, links, or user-facing documentation pages.

Concerns

  • No blocking concerns found.
  • Security pass: no security-relevant code, configuration, authentication, authorization, secrets, or data-handling changes are present in the diff.
  • Spec check: no approved or repository spec context was provided for this PR.
  • Comment/test audit: the PR does not add or modify code comments or tests.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@rachaelrenk
rachaelrenk merged commit 6bb18f3 into main Aug 28, 2026
8 checks passed
@rachaelrenk
rachaelrenk deleted the factory/reconcile-frontmatter-description-rule branch August 28, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed warpy-factory Opened by the Warp factory agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant