Align CUDA sources with C++17 - #223
Open
JensWehner wants to merge 1 commit into
Open
Conversation
Co-authored-by: GitHub Copilot <175728472+Copilot@users.noreply.github.com>
awvwgk
approved these changes
Aug 31, 2026
awvwgk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making this consistent across the codebase.
There was a problem hiding this comment.
🟢 Approval recommended
The standard declarations now match existing language usage, and all obsolete CUDA register occurrences were removed without changing kernel behavior.
Pull request overview
Aligns CUDA compilation with existing C++17 usage while removing obsolete register qualifiers.
Changes:
- Sets active and archived CUDA targets to
cuda_std_17. - Removes
registerfrom affected CUDA kernel locals.
File summaries
| File | Description |
|---|---|
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars_mgga.hpp |
Removes obsolete qualifiers from MGGA locals. |
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars_lda.hpp |
Removes the LDA qualifier. |
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars_gga.hpp |
Removes GGA local qualifiers. |
src/xc_integrator/local_work_driver/device/cuda/kernels/grid_to_center.cu |
Updates the coordinate local declaration. |
src/runtime_environment/device/cuda/CMakeLists.txt |
Requires CUDA C++17. |
attic/src/new_integrator/device/cuda/gauxc-cuda.cmake |
Updates archived CUDA standard. |
attic/src/new_integrator/device/cuda/cuda_weights.cu |
Removes an archived coordinate qualifier. |
attic/src/new_integrator/device/cuda/cuda_eval_denvars.cu |
Removes archived density-variable qualifiers. |
attic/src/integrator/cuda/gauxc-cuda_integrator.cmake |
Updates legacy CUDA standard. |
attic/src/integrator/cuda/cuda_weights.cu |
Removes a legacy coordinate qualifier. |
attic/src/integrator/cuda/cuda_eval_denvars.cu |
Removes legacy density-variable qualifiers. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GauXC’s CUDA sources are not strictly C++14-compatible because they already use C++17 features such as if constexpr. However, the build configuration declares cuda_std_14, while several kernels still use the register keyword, which was removed in C++17.
This PR aligns the declared CUDA standard with the code by:
Changing cuda_std_14 to cuda_std_17.
Removing obsolete register qualifiers that Clang diagnoses in C++17 mode.